Issue 281523003: Fix the flaky test, ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 281523003: Fix the flaky test, ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo. (Closed)

Created:
6 years, 7 months ago by ycheo (away)

Modified:
6 years, 7 months ago

Reviewers:
qinmin, xhwang

CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix the flaky test, ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo. The test is 30% failed in Galaxy Nexus, JellyBean at DCHECK(!needs_establish_peer_) of WebMediaPlayerAndroid::play(). We need to defer the steam texture creation also when we have the switch, kForceUseOverlayEmbeddedVideo. BUG=372174 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269982