ChromeOS: The centered app list's top is now forced to be >= 10.

ash/wm/app_list_controller_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/test_shell_delegate.h"
 #include "ash/wm/window_util.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/app_list/app_list_switches.h"
+#include "ui/app_list/views/app_list_view.h"
 #include "ui/aura/test/event_generator.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window.h"
 
 namespace ash {
 
+namespace {
+
+const int kMinimalCenteredAppListMargin = 10;
+
+}
+
 // The parameter is true to test the centered app list, false for normal.
 // (The test name ends in "/0" for normal, "/1" for centered.)
 class AppListControllerTest : public test::AshTestBase,
                               public ::testing::WithParamInterface<bool> {
  public:
   AppListControllerTest();
   virtual ~AppListControllerTest();
   virtual void SetUp() OVERRIDE;
 };
 
@@ skipping 101 matching lines @@
   Shell::GetInstance()->ToggleAppList(secondary_window);
   EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());
 
   // Remove the secondary display. Shouldn't crash (http://crbug.com/368990).
   UpdateDisplay("800x600");
 
   // Updating the displays should close the app list.
   EXPECT_FALSE(Shell::GetInstance()->GetAppListTargetVisibility());
 }
 
+// Tests opening the app launcher on a tiny display that is too small to contain
+// it.
+TEST_P(AppListControllerTest, TinyDisplay) {

[Matt Giuca, 2014/05/12 06:34:23]

Note: This test fails without CL 283443003 because even when GetParam() is true,
it runs the non-centered app list (which doesn't behave the way this test
expects). So this CL has a hard dependency on that one.

[varkha, 2014/05/13 03:25:31]

(Should this test and maybe other tests be disabled when the screen is not
resizable?
  if (!SupportsHostWindowResize())
    return;

[Matt Giuca, 2014/05/13 04:02:12]

Why? This test doesn't use window resizing, it just sets up an initial display
size for testing.

Note: That other CL is in now.

[varkha, 2014/05/13 04:40:11]

Unfortunately this call is a NOP on platforms that don't support display
resizing such as Windows Ash - as far as I remember trying. So it is safer to
bail out or code assertions that are clear about it.
This is true even if you set display bounds in SetUp method.

[Matt Giuca, 2014/05/13 05:31:58]

Fair enough. Done.

+  // Don't test this for the non-centered app list case; it isn't designed for
+  // small displays. The most common case of a small display --- when the
+  // virtual keyboard is open --- switches into the centered app list mode, so
+  // we just want to run this test in that case.
+  if (!GetParam())

[varkha, 2014/05/13 03:25:31]

Can we wrap this in a self-descriptive method (bool
AppListControllerTest::use_centered_app_list()) rather than use GetParam().

[Matt Giuca, 2014/05/13 04:02:12]

Done.

+    return;
+
+  // Set up a screen with a tiny display (height smaller than the app list).
+  UpdateDisplay("400x300");
+
+  Shell::GetInstance()->ToggleAppList(NULL);
+  EXPECT_TRUE(Shell::GetInstance()->GetAppListTargetVisibility());
+
+  // The top of the app list should be on-screen (even if the bottom is not).
+  // We need to manually calculate the Y coordinate of the top of the app list
+  // from the anchor (center) and height. There isn't a bounds rect that gives
+  // the actual app list position (the widget bounds include the bubble border
+  // which is much bigger than the actual app list size).
+  app_list::AppListView* app_list = Shell::GetInstance()->GetAppListView();
+  int app_list_view_top =
+      app_list->anchor_rect().y() - app_list->bounds().height() / 2;
+  EXPECT_GE(app_list_view_top, kMinimalCenteredAppListMargin);
+}
+
 INSTANTIATE_TEST_CASE_P(AppListControllerTestInstance,
                         AppListControllerTest,
                         ::testing::Bool());
 
 }  // namespace ash