Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3623)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2815183002: IPH - Added triggers to show Download Home message (Closed)
Patch Set: comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index e7b6ff72e8b1a443f6c62612b971c5eba56f7a0b..5fa8cedb94051def3a9dcad27067c288eae9c1f3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -31,10 +31,12 @@ import android.view.ViewGroup;
import android.view.Window;
import android.view.WindowManager;
import android.widget.FrameLayout;
+import android.widget.PopupWindow.OnDismissListener;
import org.chromium.base.ActivityState;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.ApplicationStatus;
+import org.chromium.base.Callback;
import org.chromium.base.CommandLine;
import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
@@ -63,6 +65,7 @@ import org.chromium.chrome.browser.device.DeviceClassManager;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.document.DocumentUtils;
import org.chromium.chrome.browser.download.DownloadUtils;
+import org.chromium.chrome.browser.feature_engagement_tracker.FeatureEngagementTrackerFactory;
import org.chromium.chrome.browser.firstrun.FirstRunActivity;
import org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer;
import org.chromium.chrome.browser.firstrun.FirstRunSignInProcessor;
@@ -116,6 +119,9 @@ import org.chromium.chrome.browser.vr_shell.VrShellDelegate;
import org.chromium.chrome.browser.widget.bottomsheet.BottomSheet;
import org.chromium.chrome.browser.widget.emptybackground.EmptyBackgroundViewWrapper;
import org.chromium.chrome.browser.widget.findinpage.FindToolbarManager;
+import org.chromium.chrome.browser.widget.textbubble.ViewAnchoredTextBubble;
+import org.chromium.components.feature_engagement_tracker.FeatureConstants;
+import org.chromium.components.feature_engagement_tracker.FeatureEngagementTracker;
import org.chromium.content.browser.ContentVideoView;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.browser.crypto.CipherFactory;
@@ -691,6 +697,15 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
mLayoutManager.hideOverview(false);
+ FeatureEngagementTracker tracker =
+ FeatureEngagementTrackerFactory.getFeatureEngagementTrackerForProfile(
+ Profile.getLastUsedProfile());
+ tracker.addOnInitializedCallback(new Callback<Boolean>() {
+ @Override
+ public void onResult(Boolean result) {
+ showFeatureEngagementTextBubbleForDownloadHome();
+ }
+ });
mUIInitialized = true;
} finally {
@@ -698,6 +713,34 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
}
}
+ private void showFeatureEngagementTextBubbleForDownloadHome() {
+ final FeatureEngagementTracker tracker =
+ FeatureEngagementTrackerFactory.getFeatureEngagementTrackerForProfile(
+ Profile.getLastUsedProfile());
+ if (!tracker.shouldTriggerHelpUI(FeatureConstants.DOWNLOAD_HOME_FEATURE)) return;
+
+ ViewAnchoredTextBubble textBubble = new ViewAnchoredTextBubble(
+ this, getToolbarManager().getMenuAnchor(), R.string.iph_download_home_text);
+ textBubble.setDismissOnTouchInteraction(true);
+ textBubble.addOnDismissListener(new OnDismissListener() {
+ @Override
+ public void onDismiss() {
+ mHandler.post(new Runnable() {
David Trainor- moved to gerrit 2017/04/25 03:45:30 If we're doing this often, maybe we should change
+ @Override
+ public void run() {
+ tracker.dismissed();
+ getAppMenuHandler().setMenuHighlight(null);
+ }
+ });
+ }
+ });
+ getAppMenuHandler().setMenuHighlight(R.id.downloads_menu_id);
+ int yInsetPx =
+ getResources().getDimensionPixelOffset(R.dimen.text_bubble_menu_anchor_y_inset);
+ textBubble.setInsetPx(0, yInsetPx, 0, 0);
+ textBubble.show();
+ }
+
private boolean isMainIntent(Intent intent) {
return intent != null && TextUtils.equals(intent.getAction(), Intent.ACTION_MAIN);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698