Chromium Code Reviews
Help | Chromium Project | Sign in
(32)

Issue 2815042: Add notifications content settings type. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Nico
Modified:
4 years ago
Reviewers:
John Gregg
CC:
chromium-reviews, John Grabowski, brettw-cc_chromium.org, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add notifications content settings type. Not used anywhere yet, no functionality change. BUG=45547 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51432

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M chrome/browser/cocoa/content_blocked_bubble_controller.mm View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/content_setting_bubble_model.cc View 5 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/content_setting_image_model.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/gtk/options/content_filter_page_gtk.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/options/content_settings_window_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/host_content_settings_map.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/host_content_settings_map_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/views/options/content_filter_page_view.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/views/options/content_settings_window_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/content_settings_types.h View 1 chunk +1 line, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Nico
4 years, 11 months ago (2010-07-01 21:27:03 UTC) #1
John Gregg
LGTM with one suggestion http://codereview.chromium.org/2815042/diff/1/2 File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right): http://codereview.chromium.org/2815042/diff/1/2#newcode121 chrome/browser/cocoa/content_blocked_bubble_controller.mm:121: COMPILE_ASSERT(arraysize(nibPaths) + 1 == CONTENT_SETTINGS_NUM_TYPES, ...
4 years, 11 months ago (2010-07-01 21:34:05 UTC) #2
Nico
4 years, 11 months ago (2010-07-01 21:43:25 UTC) #3
Thanks.

http://codereview.chromium.org/2815042/diff/1/2
File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):

http://codereview.chromium.org/2815042/diff/1/2#newcode121
chrome/browser/cocoa/content_blocked_bubble_controller.mm:121:
COMPILE_ASSERT(arraysize(nibPaths) + 1 == CONTENT_SETTINGS_NUM_TYPES,
On 2010/07/01 21:34:05, John Gregg wrote:
> given you have the CHECK_NE, it's probably better to put a "" string in
nibPaths
> instead of the +1 otherwise anything that comes along later will be broken.  

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be