Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: headless/public/util/url_fetcher.h

Issue 2815003003: Headless (breaking change): A better GenericURLRequestJob::Delegate API (Closed)
Patch Set: Changes for Sami Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/public/util/testing/generic_url_request_mocks.cc ('k') | headless/public/util/url_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/public/util/url_fetcher.h
diff --git a/headless/public/util/url_fetcher.h b/headless/public/util/url_fetcher.h
index 41bf3fa7ef0e9cdbc72804c03fd87bc5b3f874dd..df0cc0ff21635911da492fd06bc89e20dbfea183 100644
--- a/headless/public/util/url_fetcher.h
+++ b/headless/public/util/url_fetcher.h
@@ -60,17 +60,11 @@ class HEADLESS_EXPORT URLFetcher {
DISALLOW_COPY_AND_ASSIGN(ResultListener);
};
- // Instructs the sub-class to fetch the resource.
- virtual void StartFetch(const GURL& rewritten_url,
+ virtual void StartFetch(const GURL& url,
const std::string& method,
+ const std::string& post_data,
const net::HttpRequestHeaders& request_headers,
- const std::string& devtools_request_id,
- ResultListener* result_listener);
- // TODO(alexclarke): Make the above pure virtual and remove this.
- virtual void StartFetch(const GURL& rewritten_url,
- const std::string& method,
- const net::HttpRequestHeaders& request_headers,
- ResultListener* result_listener);
+ ResultListener* result_listener) = 0;
private:
DISALLOW_COPY_AND_ASSIGN(URLFetcher);
« no previous file with comments | « headless/public/util/testing/generic_url_request_mocks.cc ('k') | headless/public/util/url_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698