Headless (breaking change): A better GenericURLRequestJob::Delegate API

headless/public/util/testing/generic_url_request_mocks.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef HEADLESS_PUBLIC_UTIL_TESTING_GENERIC_URL_REQUEST_MOCKS_H_
 #define HEADLESS_PUBLIC_UTIL_TESTING_GENERIC_URL_REQUEST_MOCKS_H_
 
 #include <memory>
 #include <string>
 
 #include "base/macros.h"
 #include "headless/public/headless_export.h"
 #include "headless/public/util/generic_url_request_job.h"
 #include "headless/public/util/testing/generic_url_request_mocks.h"
 #include "net/cookies/cookie_store.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_job_factory.h"
 
 namespace headless {
 
 class HEADLESS_EXPORT MockGenericURLRequestJobDelegate
     : public GenericURLRequestJob::Delegate {
  public:
   MockGenericURLRequestJobDelegate();
   ~MockGenericURLRequestJobDelegate() override;
 
-  bool BlockOrRewriteRequest(
-      const GURL& url,
-      const std::string& devtools_id,
-      const std::string& method,
-      const std::string& referrer,
-      GenericURLRequestJob::RewriteCallback callback) override;
+  // GenericURLRequestJob::Delegate methods:
+  void OnPendingRequest(PendingRequest* pending_request) override;
+  void OnResourceLoadFailed(const Request* request, net::Error error) override;
+  void OnResourceLoadComplete(
+      const Request* request,
+      const GURL& final_url,
+      int http_response_code,
+      scoped_refptr<net::HttpResponseHeaders> response_headers,
+      const char* body,
+      size_t body_size) override;
 
-  const GenericURLRequestJob::HttpResponse* MaybeMatchResource(
-      const GURL& url,
-      const std::string& devtools_id,
-      const std::string& method,
-      const net::HttpRequestHeaders& request_headers) override;
+  using Policy = base::Callback<void(PendingRequest* pending_request)>;
 
-  void OnResourceLoadComplete(const GURL& final_url,
-                              const std::string& devtools_id,
-                              const std::string& mime_type,
-                              int http_response_code) override;
-
-  void SetShouldBlock(bool should_block) { should_block_ = should_block; }
+  void SetPolicy(Policy policy);
 
  private:
-  bool should_block_;
+  void ApplyPolicy(PendingRequest* pending_request);
+
+  Policy policy_;
   scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(MockGenericURLRequestJobDelegate);
 };
 
 // TODO(alexclarke): We may be able to replace this with the CookieMonster.
 class HEADLESS_EXPORT MockCookieStore : public net::CookieStore {
  public:
   MockCookieStore();
   ~MockCookieStore() override;
@@ skipping 84 matching lines @@
 
  private:
   std::string response_data_;
 
   DISALLOW_COPY_AND_ASSIGN(MockURLRequestDelegate);
 };
 
 }  // namespace headless
 
 #endif  // HEADLESS_PUBLIC_UTIL_TESTING_GENERIC_URL_REQUEST_MOCKS_H_