Headless (breaking change): A better GenericURLRequestJob::Delegate API

headless/public/util/deterministic_http_protocol_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "headless/public/util/deterministic_http_protocol_handler.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "headless/public/headless_browser_context.h"
 #include "headless/public/util/deterministic_dispatcher.h"
 #include "headless/public/util/generic_url_request_job.h"
 #include "headless/public/util/http_url_fetcher.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 
 namespace headless {
 
 class DeterministicHttpProtocolHandler::NopGenericURLRequestJobDelegate
     : public GenericURLRequestJob::Delegate {
  public:
   NopGenericURLRequestJobDelegate() {}
   ~NopGenericURLRequestJobDelegate() override {}
 
   // GenericURLRequestJob::Delegate methods:
-  bool BlockOrRewriteRequest(
-      const GURL& url,
-      const std::string& devtools_id,
-      const std::string& method,
-      const std::string& referrer,
-      GenericURLRequestJob::RewriteCallback callback) override {
-    return false;
+  void OnPendingRequest(PendingRequest* pending_request) override {
+    pending_request->AllowRequest();
   }
 
-  const GenericURLRequestJob::HttpResponse* MaybeMatchResource(
-      const GURL& url,
-      const std::string& devtools_id,
-      const std::string& method,
-      const net::HttpRequestHeaders& request_headers) override {
-    return nullptr;
+  void OnResourceLoadFailed(const Request* request, net::Error error) override {
   }
 
-  void OnResourceLoadComplete(const GURL& final_url,
-                              const std::string& devtools_id,
-                              const std::string& mime_type,
-                              int http_response_code) override {}
+  void OnResourceLoadComplete(
+      const Request* request,
+      const GURL& final_url,
+      int http_response_code,
+      scoped_refptr<net::HttpResponseHeaders> response_headers,
+      const char* body,
+      size_t body_size) override {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(NopGenericURLRequestJobDelegate);
 };
 
 DeterministicHttpProtocolHandler::DeterministicHttpProtocolHandler(
     DeterministicDispatcher* deterministic_dispatcher,
     scoped_refptr<base::SingleThreadTaskRunner> io_task_runner)
     : deterministic_dispatcher_(deterministic_dispatcher),
       io_task_runner_(io_task_runner),
@@ skipping 18 matching lines @@
     url_request_job_factory_.reset(new net::URLRequestJobFactoryImpl());
     url_request_context_->set_job_factory(url_request_job_factory_.get());
   }
   return new GenericURLRequestJob(
       request, network_delegate, deterministic_dispatcher_,
       base::MakeUnique<HttpURLFetcher>(url_request_context_.get()),
       nop_delegate_.get());
 }
 
 }  // namespace headless