Headless (breaking change): A better GenericURLRequestJob::Delegate API

headless/public/util/url_fetcher.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef HEADLESS_PUBLIC_UTIL_URL_FETCHER_H_
 #define HEADLESS_PUBLIC_UTIL_URL_FETCHER_H_
 
 #include <stddef.h>
 #include <string>
 #include <vector>
@@ skipping 42 matching lines @@
                                        const char* response_data,
                                        size_t response_data_size);
 
    protected:
     virtual ~ResultListener() {}
 
    private:
     DISALLOW_COPY_AND_ASSIGN(ResultListener);
   };
 
-  // Instructs the sub-class to fetch the resource.
-  virtual void StartFetch(const GURL& rewritten_url,
+  virtual void StartFetch(const GURL& url,
                           const std::string& method,
+                          const std::string& post_data,
                           const net::HttpRequestHeaders& request_headers,
-                          const std::string& devtools_request_id,
-                          ResultListener* result_listener);
-  //  TODO(alexclarke): Make the above pure virtual and remove this.
-  virtual void StartFetch(const GURL& rewritten_url,
-                          const std::string& method,
-                          const net::HttpRequestHeaders& request_headers,
-                          ResultListener* result_listener);
+                          ResultListener* result_listener) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(URLFetcher);
 };
 
 }  // namespace headless
 
 #endif  // HEADLESS_PUBLIC_UTIL_URL_FETCHER_H_