Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm

Issue 2814963002: [ios clean] Use ToolsMenuConfiguration for Menu context. (Closed)
Patch Set: Rebase and updates TabGrid menu Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
diff --git a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
index 0c2940a53a668ea7fbc9c8e2e51ade1e45b1b644..76c88ea0bcf39fff2894bd67f768893784b366e8 100644
--- a/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
+++ b/ios/clean/chrome/browser/ui/tools/menu_view_controller.mm
@@ -29,12 +29,14 @@ const CGFloat kMenuItemHeight = 48;
@property(nonatomic, strong) NSArray<ToolsMenuItem*>* menuItems;
@property(nonatomic, strong)
MenuOverflowControlsStackView* toolbarOverflowStackView;
+@property(nonatomic, assign) BOOL displaysOverflowControls;
@end
@implementation MenuViewController
@synthesize dispatcher = _dispatcher;
@synthesize menuItems = _menuItems;
@synthesize toolbarOverflowStackView = _toolbarOverflowStackView;
+@synthesize displaysOverflowControls = _displaysOverflowControls;
- (void)loadView {
CGRect frame;
@@ -79,7 +81,8 @@ const CGFloat kMenuItemHeight = 48;
// Stack view to hold overflow ToolbarButtons.
if (self.traitCollection.horizontalSizeClass ==
- UIUserInterfaceSizeClassCompact) {
+ UIUserInterfaceSizeClassCompact &&
+ self.displaysOverflowControls) {
self.toolbarOverflowStackView =
[[MenuOverflowControlsStackView alloc] init];
// PLACEHOLDER: ToolsMenuButton might end up being part of the MenuVC's view
@@ -122,4 +125,8 @@ const CGFloat kMenuItemHeight = 48;
_menuItems = menuItems;
}
+- (void)displaysOverflowControls:(BOOL)displaysOverflowControls {
+ self.displaysOverflowControls = displaysOverflowControls;
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698