ios/clean/chrome/browser/ui/tools/tools_consumer.h - Issue 2814963002: [ios clean] Use ToolsMenuConfiguration for Menu context.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/tools/tools_consumer.h

Issue 2814963002: [ios clean] Use ToolsMenuConfiguration for Menu context. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/clean/chrome/browser/ui/tools/menu_view_controller.mm ('K') | « ios/clean/chrome/browser/ui/tools/menu_view_controller.mm ('k') | ios/clean/chrome/browser/ui/tools/tools_coordinator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_CONSUMER_H_	5 #ifndef IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_CONSUMER_H_

6 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_CONSUMER_H_	6 #define IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_CONSUMER_H_

7	7

8 #import <UIKit/UIKit.h>	8 #import <UIKit/UIKit.h>

9	9

10 // ToolsConsumer sets the current appearance of the ToolsMenu based on	10 // ToolsConsumer sets the current appearance of the ToolsMenu based on

11 // various sources provided by the mediator.	11 // various sources provided by the mediator.

12 @protocol ToolsConsumer	12 @protocol ToolsConsumer

13 // PLACEHOLDER: The current methods in this protocol are not intended to be	13 // PLACEHOLDER: The current methods in this protocol are not intended to be

14 // final and might change depending on how ToolsMenuVC model is set up.	14 // final and might change depending on how ToolsMenuVC model is set up.

15 // Sets the Tools Menu items.	15 // Sets the Tools Menu items.

16 - (void)setToolsMenuItems:(NSArray*)menuItems;	16 - (void)setToolsMenuItems:(NSArray*)menuItems;

	17

	18 - (void)canDisplayOverflowControls:(BOOL)displayOverflowControls;
	sczs 2017/04/12 00:59:26 Name is not final, but any suggestions are welcome Name is not final, but any suggestions are welcome. marq (ping after 24h) 2017/04/14 10:01:52 Total nit, but: rather than -canDisplay ..., i'd Show quoted text On 2017/04/12 00:59:26, sczs wrote: > Name is not final, but any suggestions are welcome. Total nit, but: rather than -canDisplay ..., i'd just go with displaysOverflowControls ... "can" implies that this might change during the lifetime of the consumer, when it can't. sczs 2017/04/14 22:21:07 Agree, I was thinking of can because this is not t Show quoted text On 2017/04/14 10:01:52, marq wrote: > On 2017/04/12 00:59:26, sczs wrote: > > Name is not final, but any suggestions are welcome. > > Total nit, but: > > rather than -canDisplay ..., i'd just go with displaysOverflowControls ... > > "can" implies that this might change during the lifetime of the consumer, when > it can't. Agree, I was thinking of can because this is not the only criteria for showing the Menu. I'll change it since I think its more important to not give the impression it changes over the lifetime of the consumer.
17 @end	19 @end

18	20

19 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_CONSUMER_H_	21 #endif // IOS_CLEAN_CHROME_BROWSER_UI_TOOLS_TOOLS_CONSUMER_H_

OLD	NEW