[ios clean] Use ToolsMenuConfiguration for Menu context.

ios/clean/chrome/browser/ui/tools/menu_view_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/tools/menu_view_controller.h"
 
 #include "base/i18n/rtl.h"
 #import "base/logging.h"
 #import "base/macros.h"
 #import "ios/chrome/browser/ui/rtl_geometry.h"
 #import "ios/clean/chrome/browser/ui/commands/tools_menu_commands.h"
 #import "ios/clean/chrome/browser/ui/toolbar/toolbar_button.h"
 #import "ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h"
 #import "ios/clean/chrome/browser/ui/tools/tools_menu_item.h"
 #import "ios/third_party/material_components_ios/src/components/Typography/src/MaterialTypography.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
 const CGFloat kMenuWidth = 250;
 const CGFloat kMenuItemHeight = 48;
 }
 
 @interface MenuViewController ()
 @property(nonatomic, strong) NSArray<ToolsMenuItem*>* menuItems;
 @property(nonatomic, strong)
     MenuOverflowControlsStackView* toolbarOverflowStackView;
+@property(nonatomic, assign) BOOL displayOverflowControls;
 @end
 
 @implementation MenuViewController
 @synthesize menuItems = _menuItems;
 @synthesize toolbarOverflowStackView = _toolbarOverflowStackView;
 @synthesize dispatcher = _dispatcher;
+@synthesize displayOverflowControls = _displayOverflowControls;
 
 - (void)loadView {
   CGRect frame;
   frame.size = CGSizeMake(kMenuWidth, kMenuItemHeight * _menuItems.count);
   frame.origin = CGPointZero;
   self.view = [[UIView alloc] initWithFrame:frame];
   self.view.backgroundColor = [UIColor whiteColor];
   self.view.autoresizingMask = UIViewAutoresizingNone;
   self.view.layer.borderColor = [UIColor clearColor].CGColor;
 }
@@ skipping 23 matching lines @@
 
   // Placeholder stack view to hold menu contents.
   UIStackView* menu = [[UIStackView alloc] initWithArrangedSubviews:buttons];
   menu.translatesAutoresizingMaskIntoConstraints = NO;
   menu.axis = UILayoutConstraintAxisVertical;
   menu.distribution = UIStackViewDistributionFillEqually;
   menu.alignment = UIStackViewAlignmentLeading;
 
   // Stack view to hold overflow ToolbarButtons.
   if (self.traitCollection.horizontalSizeClass ==
-      UIUserInterfaceSizeClassCompact) {
+          UIUserInterfaceSizeClassCompact &&
+      self.displayOverflowControls) {
     self.toolbarOverflowStackView =
         [[MenuOverflowControlsStackView alloc] init];
     // PLACEHOLDER: ToolsMenuButton might end up being part of the MenuVC's view
     // instead of the StackView. We are waiting confirmation on this.
     [self.toolbarOverflowStackView.toolsMenuButton
                addTarget:nil
                   action:@selector(closeToolsMenu:)
         forControlEvents:UIControlEventTouchUpInside];
     [menu insertArrangedSubview:self.toolbarOverflowStackView atIndex:0];
     [NSLayoutConstraint activateConstraints:@[
@@ skipping 18 matching lines @@
 - (void)closeToolsMenu:(id)sender {
   [self.dispatcher closeToolsMenu];
 }
 
 #pragma mark - Tools Consumer
 
 - (void)setToolsMenuItems:(NSArray*)menuItems {
   _menuItems = menuItems;
 }
 
+- (void)canDisplayOverflowControls:(BOOL)displayOverflowControls {

[marq (ping after 24h), 2017/04/12 11:17:07]

This depends on device size/format, which is something I've been trying to keep
confined to the view controller layer. What do we gain by having this pushed in
from the mediator?

[sczs, 2017/04/12 15:06:08]

This also depends on who is displaying the ToolsMenu, since we won't display the
overflow controls on the TabGrid ToolsMenu for example.

[marq (ping after 24h), 2017/04/14 10:01:52]

Indeed! My mistake.

+  self.displayOverflowControls = displayOverflowControls;
+}
+
 @end