Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.cc

Issue 2814863002: cros: Allow JS to control virtual keyboard on sign-in screen. (Closed)
Patch Set: Remove login_display_host_impl.cc keyboard logic Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/lock/webui_screen_locker.cc
diff --git a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
index 8eb0e41b6aa99705a1aaaa55d59ff63db1309f15..e4c0251774dd3ef419d1eab9e910f96e6438b4cb 100644
--- a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
+++ b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
@@ -43,7 +43,6 @@
#include "ui/base/x/x11_util.h"
#include "ui/display/display.h"
#include "ui/display/screen.h"
-#include "ui/keyboard/keyboard_controller.h"
#include "ui/keyboard/keyboard_util.h"
#include "ui/views/controls/webview/webview.h"
@@ -126,21 +125,14 @@ WebUIScreenLocker::WebUIScreenLocker(ScreenLocker* screen_locker)
weak_factory_(this) {
set_should_emit_login_prompt_visible(false);
ash::ShellPort::Get()->AddLockStateObserver(this);
- ash::Shell::Get()->AddShellObserver(this);
display::Screen::GetScreen()->AddObserver(this);
DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this);
-
- if (keyboard::KeyboardController::GetInstance()) {
- keyboard::KeyboardController::GetInstance()->AddObserver(this);
- is_observing_keyboard_ = true;
- }
}
WebUIScreenLocker::~WebUIScreenLocker() {
DBusThreadManager::Get()->GetPowerManagerClient()->RemoveObserver(this);
display::Screen::GetScreen()->RemoveObserver(this);
ash::ShellPort::Get()->RemoveLockStateObserver(this);
- ash::Shell::Get()->RemoveShellObserver(this);
// In case of shutdown, lock_window_ may be deleted before WebUIScreenLocker.
if (lock_window_) {
lock_window_->RemoveObserver(this);
@@ -151,11 +143,6 @@ WebUIScreenLocker::~WebUIScreenLocker() {
if (login_display_.get() && GetOobeUI())
GetOobeUI()->ResetSigninScreenHandlerDelegate();
- if (keyboard::KeyboardController::GetInstance() && is_observing_keyboard_) {
- keyboard::KeyboardController::GetInstance()->RemoveObserver(this);
- is_observing_keyboard_ = false;
- }
-
ResetKeyboardOverscrollOverride();
RequestPreload();
@@ -414,47 +401,6 @@ void WebUIScreenLocker::RenderProcessGone(base::TerminationStatus status) {
}
////////////////////////////////////////////////////////////////////////////////
-// ash::ShellObserver:
-
-void WebUIScreenLocker::OnVirtualKeyboardStateChanged(
- bool activated,
- ash::WmWindow* root_window) {
- if (keyboard::KeyboardController::GetInstance()) {
- if (activated) {
- if (!is_observing_keyboard_) {
- keyboard::KeyboardController::GetInstance()->AddObserver(this);
- is_observing_keyboard_ = true;
- }
- } else {
- keyboard::KeyboardController::GetInstance()->RemoveObserver(this);
- is_observing_keyboard_ = false;
- }
- }
-}
-
-////////////////////////////////////////////////////////////////////////////////
-// keyboard::KeyboardControllerObserver:
-
-void WebUIScreenLocker::OnKeyboardBoundsChanging(
- const gfx::Rect& new_bounds) {
- if (new_bounds.IsEmpty()) {
- // Keyboard has been hidden.
- if (GetOobeUI()) {
- GetOobeUI()->GetCoreOobeView()->ShowControlBar(true);
- GetOobeUI()->GetCoreOobeView()->ShowPinKeyboard(true);
- }
- } else {
- // Keyboard has been shown.
- if (GetOobeUI()) {
- GetOobeUI()->GetCoreOobeView()->ShowControlBar(false);
- GetOobeUI()->GetCoreOobeView()->ShowPinKeyboard(false);
- }
- }
-}
-
-void WebUIScreenLocker::OnKeyboardClosed() {}
-
-////////////////////////////////////////////////////////////////////////////////
// display::DisplayObserver:
void WebUIScreenLocker::OnDisplayAdded(const display::Display& new_display) {}
« no previous file with comments | « chrome/browser/chromeos/login/lock/webui_screen_locker.h ('k') | chrome/browser/chromeos/login/screens/core_oobe_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698