Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: ui/display/display_layout_builder.cc

Issue 2814843007: Fix expected PlacementList sort order. (Closed)
Patch Set: Don't register invalid layouts Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/display/display_layout_builder.cc
diff --git a/ui/display/display_layout_builder.cc b/ui/display/display_layout_builder.cc
index 43527ede756fa6a7dcce2ec5cbf1f05daffe86ef..add0d3864ec2accf8272b0287bfa8293fd204e70 100644
--- a/ui/display/display_layout_builder.cc
+++ b/ui/display/display_layout_builder.cc
@@ -6,6 +6,8 @@
#include <algorithm>
+#include "ui/display/display.h"
+
namespace display {
DisplayLayoutBuilder::DisplayLayoutBuilder(const DisplayLayout& layout)
@@ -66,7 +68,7 @@ DisplayLayoutBuilder& DisplayLayoutBuilder::SetSecondaryPlacement(
std::unique_ptr<DisplayLayout> DisplayLayoutBuilder::Build() {
std::sort(layout_->placement_list.begin(), layout_->placement_list.end(),
[](const DisplayPlacement& a, const DisplayPlacement& b) {
- return a.display_id < b.display_id;
+ return CompareDisplayIds(a.display_id, b.display_id);
});
return std::move(layout_);
}

Powered by Google App Engine
This is Rietveld 408576698