ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm - Issue 2814813003: [ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc_transition to ARC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm

Issue 2814813003: [ObjC ARC] Converts ios/chrome/browser/ui/settings:settings_arc_transition to ARC. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/settings/do_not_track_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/import_data_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm b/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm

index 8fcca0939ced9304ffa912899d0fd20619c707d7..57d5425706bcd1fb01988060f311d4a1311048d8 100644

--- a/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/handoff_collection_view_controller.mm

@@ -15,6 +15,10 @@

#include "ios/chrome/grit/ios_strings.h"

#include "ui/base/l10n/l10n_util.h"

+#if !defined(__has_feature) || !__has_feature(objc_arc)

+#error "This file requires ARC support."

+#endif

namespace {

typedef NS_ENUM(NSInteger, SectionIdentifier) {

@@ -61,8 +65,8 @@ typedef NS_ENUM(NSInteger, ItemType) {

CollectionViewModel* model = self.collectionViewModel;

[model addSectionWithIdentifier:SectionIdentifierSwitch];

- CollectionViewSwitchItem* switchItem = [[[CollectionViewSwitchItem alloc]

- initWithType:ItemTypeSwitch] autorelease];

+ CollectionViewSwitchItem* switchItem =

+ [[CollectionViewSwitchItem alloc] initWithType:ItemTypeSwitch];

switchItem.text =

l10n_util::GetNSString(IDS_IOS_OPTIONS_ENABLE_HANDOFF_TO_OTHER_DEVICES);

switchItem.on = _handoffEnabled.GetValue();

@@ -72,8 +76,8 @@ typedef NS_ENUM(NSInteger, ItemType) {

// drawing bug in MDC.

// TODO(crbug.com/650424) Use setFooter:forSectionWithIdentifier:.

[model addSectionWithIdentifier:SectionIdentifierFooter];

- CollectionViewFooterItem* footer = [[[CollectionViewFooterItem alloc]

- initWithType:ItemTypeFooter] autorelease];

+ CollectionViewFooterItem* footer =

+ [[CollectionViewFooterItem alloc] initWithType:ItemTypeFooter];

footer.text = l10n_util::GetNSString(

IDS_IOS_OPTIONS_ENABLE_HANDOFF_TO_OTHER_DEVICES_DETAILS);

[model addItem:footer toSectionWithIdentifier:SectionIdentifierFooter];