Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: ios/chrome/app/BUILD.gn

Issue 2814783003: Rename widget to search widget and use new bundleid to always build. (Closed)
Patch Set: md + comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/rules.gni") 5 import("//build/config/ios/rules.gni")
6 import("//build/config/mac/base_rules.gni") 6 import("//build/config/mac/base_rules.gni")
7 import("//build/mac/tweak_info_plist.gni") 7 import("//build/mac/tweak_info_plist.gni")
8 import("//ios/build/chrome_build.gni") 8 import("//ios/build/chrome_build.gni")
9 import("//ios/public/provider/chrome/browser/build_config.gni") 9 import("//ios/public/provider/chrome/browser/build_config.gni")
10 10
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 ":main", 267 ":main",
268 ":tests_fake_hook", 268 ":tests_fake_hook",
269 ] 269 ]
270 270
271 bundle_deps = [ "//ios/chrome/app/resources" ] 271 bundle_deps = [ "//ios/chrome/app/resources" ]
272 272
273 if (current_toolchain == default_toolchain) { 273 if (current_toolchain == default_toolchain) {
274 if (ios_enable_today_extension) { 274 if (ios_enable_today_extension) {
275 deps += [ ":today_extension_bundle" ] 275 deps += [ ":today_extension_bundle" ]
276 } 276 }
277 if (ios_enable_widget_extension) { 277 if (ios_enable_search_widget_extension) {
278 deps += [ ":widget_extension_bundle" ] 278 deps += [ ":search_widget_extension_bundle" ]
279 } 279 }
280 if (ios_enable_share_extension) { 280 if (ios_enable_share_extension) {
281 deps += [ ":share_extension_bundle" ] 281 deps += [ ":share_extension_bundle" ]
282 } 282 }
283 } 283 }
284 284
285 extra_substitutions = [ 285 extra_substitutions = [
286 "CHROMIUM_BUNDLE_ID=$chromium_bundle_id", 286 "CHROMIUM_BUNDLE_ID=$chromium_bundle_id",
287 "CHROMIUM_HANDOFF_ID=$chromium_handoff_id", 287 "CHROMIUM_HANDOFF_ID=$chromium_handoff_id",
288 "CHROMIUM_SHORT_NAME=$chromium_short_name", 288 "CHROMIUM_SHORT_NAME=$chromium_short_name",
(...skipping 18 matching lines...) Expand all
307 ] 307 ]
308 sources = [ 308 sources = [
309 "$root_out_dir/today_extension.appex", 309 "$root_out_dir/today_extension.appex",
310 ] 310 ]
311 outputs = [ 311 outputs = [
312 "{{bundle_plugins_dir}}/{{source_file_part}}", 312 "{{bundle_plugins_dir}}/{{source_file_part}}",
313 ] 313 ]
314 } 314 }
315 } 315 }
316 316
317 if (ios_enable_widget_extension) { 317 if (ios_enable_search_widget_extension) {
318 bundle_data("widget_extension_bundle") { 318 bundle_data("search_widget_extension_bundle") {
319 public_deps = [ 319 public_deps = [
320 "//ios/chrome/widget_extension", 320 "//ios/chrome/search_widget_extension",
321 ] 321 ]
322 sources = [ 322 sources = [
323 "$root_out_dir/widget_extension.appex", 323 "$root_out_dir/search_widget_extension.appex",
324 ] 324 ]
325
326 # The output is renamed today_extension.appex so that signing in canary
327 # works and clobbering is not necessary when switching between this
328 # extension and the today extension.
329 # TODO(crbug.com/682230) : Rename this when widget gets its own
marq (ping after 24h) 2017/04/13 12:09:23 Should this bug also be on the BUG line?
lody 2017/04/13 15:36:34 Done.
330 # mobileprovision.
331 outputs = [ 325 outputs = [
332 "{{bundle_plugins_dir}}/today_extension.appex", 326 "{{bundle_plugins_dir}}/{{source_file_part}}",
333 ] 327 ]
334 } 328 }
335 } 329 }
336 330
337 if (ios_enable_share_extension) { 331 if (ios_enable_share_extension) {
338 bundle_data("share_extension_bundle") { 332 bundle_data("share_extension_bundle") {
339 public_deps = [ 333 public_deps = [
340 "//ios/chrome/share_extension", 334 "//ios/chrome/share_extension",
341 ] 335 ]
342 sources = [ 336 sources = [
343 "$root_out_dir/share_extension.appex", 337 "$root_out_dir/share_extension.appex",
344 ] 338 ]
345 outputs = [ 339 outputs = [
346 "{{bundle_plugins_dir}}/{{source_file_part}}", 340 "{{bundle_plugins_dir}}/{{source_file_part}}",
347 ] 341 ]
348 } 342 }
349 } 343 }
350 } 344 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698