Move password-related methods from core.js to password_controller.js.

ios/chrome/browser/passwords/resources/password_controller.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file adheres to closure-compiler conventions in order to enable
 // compilation with ADVANCED_OPTIMIZATIONS. See http://goo.gl/FwOgy
 //
 // Installs password management functions on the |__gCrWeb| object.
 //
 // Finds all password forms in the current document and extracts
@@ skipping 10 matching lines @@
 // Only install the password management functions once.
 if (__gCrWeb && !__gCrWeb['fillPasswordForm']) {
 
   /**
    * Finds all password forms in the window and returns form data as a JSON
    * string.
    * @return {string} Form data as a JSON string.
    */
   __gCrWeb['findPasswordForms'] = function() {
     var formDataList = [];
-    if (__gCrWeb.hasPasswordField()) {
+    if (hasPasswordField_(window)) {
       __gCrWeb.getPasswordFormDataList(formDataList, window);
     }
     return __gCrWeb.stringify(formDataList);
   };
 
   /**
+   * Returns true if the top window or any frames inside contain an input field
+   * of type 'password'. This method is only used for unit tests and are only
+   * kept for legacy reasons. Prefer to use the private
+   * {@code hasPasswordField_} within this file.
+   * @return {boolean} Whether a password field exists.
+   *
+   * TODO(danyao): investigate if this method can be completely removed from the

[Eugene But (OOO till 7-30), 2017/04/11 16:19:40]

Per Google's Unit Testing Best Practices: "Test code using real APIs - don’t
define back doors only for tests.". go/unit-test-practices?cl=head#public-apis

Should we keep this method public (w/o TestOnly suffix) until there is a better
way to test the code?

[Eugene But (OOO till 7-30), 2017/04/11 16:19:40]

In Chrome for iOS we use |TODO(crbug.com/<bug number>)| format, because when
people leave comments don't get updated :)

[danyao, 2017/04/11 18:05:06]

Done. This seems too small to warrant its own bug. I've added crbug.com/614092
here and will investigate right away after this CL.

[danyao, 2017/04/11 18:05:06]

Done.

+   * gCrWeb public interface.
+   */
+  __gCrWeb['hasPasswordFieldTestOnly'] = function() {
+    return hasPasswordField_(window);
+  };
+
+  /** Returns true if the supplied window or any frames inside contain an input
+   * field of type 'password'.
+   * @private
+   */
+  var hasPasswordField_ = function(win) {
+    var doc = win.document;
+
+    // We may will not be allowed to read the 'document' property from a frame
+    // that is in a different domain.
+    if (!doc) {
+      return false;
+    }
+
+    if (doc.querySelector('input[type=password]')) {
+      return true;
+    }
+
+    var frames = win.frames;
+    for (var i = 0; i < frames.length; i++) {
+      if (hasPasswordField_(frames[i])) {
+        return true;
+      }
+    }
+
+    return false;
+  };
+
+
+  /**
    * Returns the password form with the given |name| as a JSON string.
    * @param {string} name The name of the form to extract.
    * @return {string} The password form.
    */
   __gCrWeb['getPasswordForm'] = function(name) {
     var el = __gCrWeb.common.getFormElementFromIdentifier(name);
     if (!el)
       return 'noPasswordsFound';
     var formData = __gCrWeb.getPasswordFormData(el);
     if (!formData)
@@ skipping 378 matching lines @@
       'method': formElement.getAttribute('method'),
       'name': __gCrWeb.common.getFormIdentifier(formElement),
       'origin': origin,
       'fields': fields,
       'usernameElement': usernameElement,
       'usernameValue': usernameValue,
       'passwords': passwords
     };
   };
 }