src/compiler/ia32/code-generator-ia32.cc - Issue 2814753003: [SAB] Validate index before value conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 2814753003: [SAB] Validate index before value conversion (Closed)

Patch Set: feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ia32/code-generator-ia32.cc

diff --git a/src/compiler/ia32/code-generator-ia32.cc b/src/compiler/ia32/code-generator-ia32.cc

index 9dbf19c3f59eb0d0d393040e00916eb5cb9af52e..dabdab3810947a32cc054541b5c68b94e7cffe21 100644

--- a/src/compiler/ia32/code-generator-ia32.cc

+++ b/src/compiler/ia32/code-generator-ia32.cc

@@ -780,7 +780,7 @@ class OutOfLineRecordWrite final : public OutOfLineCode {

Label binop; \

__ bind(&binop); \

__ mov_inst(eax, i.MemoryOperand(1)); \

- __ mov_inst(i.TempRegister(0), Operand(eax)); \

+ __ Move(i.TempRegister(0), eax); \

__ bin_inst(i.TempRegister(0), i.InputRegister(0)); \

__ lock(); \

__ cmpxchg_inst(i.MemoryOperand(1), i.TempRegister(0)); \