chrome/browser/search/one_google_bar/one_google_bar_fetcher.h - Issue 2814753002: Local NTP: Introduce OneGoogleBarFetcher

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/search/one_google_bar/one_google_bar_fetcher.h

Issue 2814753002: Local NTP: Introduce OneGoogleBarFetcher (Closed)

Patch Set: copy ctor Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SEARCH_ONE_GOOGLE_BAR_ONE_GOOGLE_BAR_FETCHER_H_

	6 #define CHROME_BROWSER_SEARCH_ONE_GOOGLE_BAR_ONE_GOOGLE_BAR_FETCHER_H_

	7

	8 #include "base/callback_forward.h"

	9 #include "base/optional.h"

	10

	11 struct OneGoogleBarData;

	12

	13 class OneGoogleBarFetcher {

	14 public:

	15 using OneGoogleCallback =

	16 base::OnceCallback<void(const base::Optional<OneGoogleBarData>&)>;

	17

	18 virtual void Fetch(OneGoogleCallback callback) = 0;
	sfiera 2017/04/12 17:25:47 Comments? In particular, I would wonder if the ca Comments? In particular, I would wonder if the caller, callee, or neither should be caching the result. Marc Treib 2017/04/13 09:03:34 Added a comment which hopefully makes things clear Show quoted text On 2017/04/12 17:25:47, sfiera wrote: > Comments? > > In particular, I would wonder if the caller, callee, or neither should be > caching the result. Added a comment which hopefully makes things clear - the fetcher just fetches and doesn't know or care about caching.
	19 };

	20

	21 #endif // CHROME_BROWSER_SEARCH_ONE_GOOGLE_BAR_ONE_GOOGLE_BAR_FETCHER_H_

OLD	NEW