OLD | NEW |
(Empty) | |
| 1 // Copyright 2017 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. |
| 4 |
| 5 #include "chrome/browser/search/one_google_bar/one_google_bar_fetcher_impl.h" |
| 6 |
| 7 #include "base/macros.h" |
| 8 #include "base/memory/ptr_util.h" |
| 9 #include "base/memory/ref_counted.h" |
| 10 #include "base/message_loop/message_loop.h" |
| 11 #include "base/run_loop.h" |
| 12 #include "base/test/mock_callback.h" |
| 13 #include "base/test/test_simple_task_runner.h" |
| 14 #include "base/time/time.h" |
| 15 #include "chrome/browser/search/one_google_bar/one_google_bar_data.h" |
| 16 #include "components/google/core/browser/google_url_tracker.h" |
| 17 #include "components/safe_json/testing_json_parser.h" |
| 18 #include "components/signin/core/browser/account_tracker_service.h" |
| 19 #include "components/signin/core/browser/fake_profile_oauth2_token_service.h" |
| 20 #include "components/signin/core/browser/fake_signin_manager.h" |
| 21 #include "components/signin/core/browser/test_signin_client.h" |
| 22 #include "components/sync_preferences/testing_pref_service_syncable.h" |
| 23 #include "google_apis/gaia/fake_oauth2_token_service_delegate.h" |
| 24 #include "net/http/http_request_headers.h" |
| 25 #include "net/http/http_status_code.h" |
| 26 #include "net/url_request/test_url_fetcher_factory.h" |
| 27 #include "net/url_request/url_request_status.h" |
| 28 #include "net/url_request/url_request_test_util.h" |
| 29 #include "testing/gmock/include/gmock/gmock.h" |
| 30 #include "testing/gtest/include/gtest/gtest.h" |
| 31 |
| 32 using testing::_; |
| 33 using testing::Eq; |
| 34 using testing::IsEmpty; |
| 35 using testing::SaveArg; |
| 36 using testing::StartsWith; |
| 37 |
| 38 namespace { |
| 39 |
| 40 const char kMinimalValidResponse[] = R"json({"oneGoogleBar": { |
| 41 "html": { "privateDoNotAccessOrElseSafeHtmlWrappedValue": "" }, |
| 42 "pageHooks": {} |
| 43 }})json"; |
| 44 |
| 45 // Required to instantiate a GoogleUrlTracker in UNIT_TEST_MODE. |
| 46 class GoogleURLTrackerClientStub : public GoogleURLTrackerClient { |
| 47 public: |
| 48 GoogleURLTrackerClientStub() {} |
| 49 ~GoogleURLTrackerClientStub() override {} |
| 50 |
| 51 bool IsBackgroundNetworkingEnabled() override { return true; } |
| 52 PrefService* GetPrefs() override { return nullptr; } |
| 53 net::URLRequestContextGetter* GetRequestContext() override { return nullptr; } |
| 54 |
| 55 private: |
| 56 DISALLOW_COPY_AND_ASSIGN(GoogleURLTrackerClientStub); |
| 57 }; |
| 58 |
| 59 } // namespace |
| 60 |
| 61 class OneGoogleBarFetcherImplTest : public testing::Test { |
| 62 public: |
| 63 OneGoogleBarFetcherImplTest() |
| 64 : signin_client_(&pref_service_), |
| 65 signin_manager_(&signin_client_, &account_tracker_), |
| 66 task_runner_(new base::TestSimpleTaskRunner()), |
| 67 request_context_getter_( |
| 68 new net::TestURLRequestContextGetter(task_runner_)), |
| 69 token_service_(base::MakeUnique<FakeOAuth2TokenServiceDelegate>( |
| 70 request_context_getter_.get())), |
| 71 google_url_tracker_(base::MakeUnique<GoogleURLTrackerClientStub>(), |
| 72 GoogleURLTracker::UNIT_TEST_MODE), |
| 73 one_google_bar_fetcher_(&signin_manager_, |
| 74 &token_service_, |
| 75 request_context_getter_.get(), |
| 76 &google_url_tracker_) { |
| 77 SigninManagerBase::RegisterProfilePrefs(pref_service_.registry()); |
| 78 SigninManagerBase::RegisterPrefs(pref_service_.registry()); |
| 79 } |
| 80 |
| 81 void SignIn() { |
| 82 signin_manager_.SignIn("account"); |
| 83 token_service_.GetDelegate()->UpdateCredentials("account", "refresh_token"); |
| 84 } |
| 85 |
| 86 void IssueAccessToken() { |
| 87 token_service_.IssueAllTokensForAccount( |
| 88 "account", "access_token", |
| 89 base::Time::Now() + base::TimeDelta::FromHours(1)); |
| 90 } |
| 91 |
| 92 void IssueAccessTokenError() { |
| 93 token_service_.IssueErrorForAllPendingRequestsForAccount( |
| 94 "account", |
| 95 GoogleServiceAuthError(GoogleServiceAuthError::SERVICE_UNAVAILABLE)); |
| 96 } |
| 97 |
| 98 net::TestURLFetcher* GetRunningURLFetcher() { |
| 99 // All created URLFetchers have ID 0 by default. |
| 100 net::TestURLFetcher* url_fetcher = url_fetcher_factory_.GetFetcherByID(0); |
| 101 DCHECK(url_fetcher); |
| 102 return url_fetcher; |
| 103 } |
| 104 |
| 105 void RespondWithData(const std::string& data) { |
| 106 net::TestURLFetcher* url_fetcher = GetRunningURLFetcher(); |
| 107 url_fetcher->set_status(net::URLRequestStatus()); |
| 108 url_fetcher->set_response_code(net::HTTP_OK); |
| 109 url_fetcher->SetResponseString(data); |
| 110 url_fetcher->delegate()->OnURLFetchComplete(url_fetcher); |
| 111 // SafeJsonParser is asynchronous. |
| 112 base::RunLoop().RunUntilIdle(); |
| 113 } |
| 114 |
| 115 OneGoogleBarFetcherImpl* one_google_bar_fetcher() { |
| 116 return &one_google_bar_fetcher_; |
| 117 } |
| 118 |
| 119 private: |
| 120 // variations::AppendVariationHeaders and SafeJsonParser require a |
| 121 // ThreadTaskRunnerHandle to be set. |
| 122 base::MessageLoop message_loop_; |
| 123 |
| 124 safe_json::TestingJsonParser::ScopedFactoryOverride factory_override_; |
| 125 |
| 126 net::TestURLFetcherFactory url_fetcher_factory_; |
| 127 sync_preferences::TestingPrefServiceSyncable pref_service_; |
| 128 |
| 129 TestSigninClient signin_client_; |
| 130 AccountTrackerService account_tracker_; |
| 131 FakeSigninManagerBase signin_manager_; |
| 132 |
| 133 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; |
| 134 scoped_refptr<net::TestURLRequestContextGetter> request_context_getter_; |
| 135 FakeProfileOAuth2TokenService token_service_; |
| 136 GoogleURLTracker google_url_tracker_; |
| 137 |
| 138 OneGoogleBarFetcherImpl one_google_bar_fetcher_; |
| 139 }; |
| 140 |
| 141 TEST_F(OneGoogleBarFetcherImplTest, UnauthenticatedRequestReturns) { |
| 142 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> callback; |
| 143 one_google_bar_fetcher()->Fetch(callback.Get()); |
| 144 |
| 145 base::Optional<OneGoogleBarData> data; |
| 146 EXPECT_CALL(callback, Run(_)).WillOnce(SaveArg<0>(&data)); |
| 147 RespondWithData(kMinimalValidResponse); |
| 148 |
| 149 EXPECT_TRUE(data.has_value()); |
| 150 } |
| 151 |
| 152 TEST_F(OneGoogleBarFetcherImplTest, AuthenticatedRequestReturns) { |
| 153 SignIn(); |
| 154 |
| 155 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> callback; |
| 156 one_google_bar_fetcher()->Fetch(callback.Get()); |
| 157 |
| 158 IssueAccessToken(); |
| 159 |
| 160 base::Optional<OneGoogleBarData> data; |
| 161 EXPECT_CALL(callback, Run(_)).WillOnce(SaveArg<0>(&data)); |
| 162 RespondWithData(kMinimalValidResponse); |
| 163 |
| 164 EXPECT_TRUE(data.has_value()); |
| 165 } |
| 166 |
| 167 TEST_F(OneGoogleBarFetcherImplTest, UnauthenticatedRequestHasApiKey) { |
| 168 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> callback; |
| 169 one_google_bar_fetcher()->Fetch(callback.Get()); |
| 170 |
| 171 // The request should have an API key (as a query param). |
| 172 EXPECT_THAT(GetRunningURLFetcher()->GetOriginalURL().query(), |
| 173 StartsWith("key=")); |
| 174 |
| 175 // But no "Authorization" header. |
| 176 net::HttpRequestHeaders headers; |
| 177 GetRunningURLFetcher()->GetExtraRequestHeaders(&headers); |
| 178 EXPECT_FALSE(headers.HasHeader("Authorization")); |
| 179 } |
| 180 |
| 181 TEST_F(OneGoogleBarFetcherImplTest, AuthenticatedRequestHasAuthHeader) { |
| 182 SignIn(); |
| 183 |
| 184 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> callback; |
| 185 one_google_bar_fetcher()->Fetch(callback.Get()); |
| 186 |
| 187 IssueAccessToken(); |
| 188 |
| 189 // The request should *not* have an API key (as a query param). |
| 190 EXPECT_THAT(GetRunningURLFetcher()->GetOriginalURL().query(), IsEmpty()); |
| 191 |
| 192 // It should have an "Authorization" header. |
| 193 net::HttpRequestHeaders headers; |
| 194 GetRunningURLFetcher()->GetExtraRequestHeaders(&headers); |
| 195 EXPECT_TRUE(headers.HasHeader("Authorization")); |
| 196 } |
| 197 |
| 198 TEST_F(OneGoogleBarFetcherImplTest, |
| 199 AuthenticatedRequestFallsBackToUnauthenticated) { |
| 200 SignIn(); |
| 201 |
| 202 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> callback; |
| 203 one_google_bar_fetcher()->Fetch(callback.Get()); |
| 204 |
| 205 IssueAccessTokenError(); |
| 206 |
| 207 // The request should have fallen back to unauthenticated mode with an API key |
| 208 // (as a query param). |
| 209 EXPECT_THAT(GetRunningURLFetcher()->GetOriginalURL().query(), |
| 210 StartsWith("key=")); |
| 211 |
| 212 // But no "Authorization" header. |
| 213 net::HttpRequestHeaders headers; |
| 214 GetRunningURLFetcher()->GetExtraRequestHeaders(&headers); |
| 215 EXPECT_FALSE(headers.HasHeader("Authorization")); |
| 216 } |
| 217 |
| 218 TEST_F(OneGoogleBarFetcherImplTest, HandlesResponsePreamble) { |
| 219 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> callback; |
| 220 one_google_bar_fetcher()->Fetch(callback.Get()); |
| 221 |
| 222 // The reponse may contain a ")]}'" prefix. The fetcher should ignore that |
| 223 // during parsing. |
| 224 base::Optional<OneGoogleBarData> data; |
| 225 EXPECT_CALL(callback, Run(_)).WillOnce(SaveArg<0>(&data)); |
| 226 RespondWithData(std::string(")]}'") + kMinimalValidResponse); |
| 227 |
| 228 EXPECT_TRUE(data.has_value()); |
| 229 } |
| 230 |
| 231 TEST_F(OneGoogleBarFetcherImplTest, ParsesFullResponse) { |
| 232 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> callback; |
| 233 one_google_bar_fetcher()->Fetch(callback.Get()); |
| 234 |
| 235 base::Optional<OneGoogleBarData> data; |
| 236 EXPECT_CALL(callback, Run(_)).WillOnce(SaveArg<0>(&data)); |
| 237 RespondWithData(R"json({"oneGoogleBar": { |
| 238 "html": { "privateDoNotAccessOrElseSafeHtmlWrappedValue": "bar_html" }, |
| 239 "pageHooks": { |
| 240 "inHeadScript": { |
| 241 "privateDoNotAccessOrElseSafeScriptWrappedValue": "in_head_script" |
| 242 }, |
| 243 "inHeadStyle": { |
| 244 "privateDoNotAccessOrElseSafeStyleSheetWrappedValue": "in_head_style" |
| 245 }, |
| 246 "afterBarScript": { |
| 247 "privateDoNotAccessOrElseSafeScriptWrappedValue": "after_bar_script" |
| 248 }, |
| 249 "endOfBodyHtml": { |
| 250 "privateDoNotAccessOrElseSafeHtmlWrappedValue": "end_of_body_html" |
| 251 }, |
| 252 "endOfBodyScript": { |
| 253 "privateDoNotAccessOrElseSafeScriptWrappedValue": "end_of_body_script" |
| 254 } |
| 255 } |
| 256 }})json"); |
| 257 |
| 258 ASSERT_TRUE(data.has_value()); |
| 259 EXPECT_THAT(data->bar_html, Eq("bar_html")); |
| 260 EXPECT_THAT(data->in_head_script, Eq("in_head_script")); |
| 261 EXPECT_THAT(data->in_head_style, Eq("in_head_style")); |
| 262 EXPECT_THAT(data->after_bar_script, Eq("after_bar_script")); |
| 263 EXPECT_THAT(data->end_of_body_html, Eq("end_of_body_html")); |
| 264 EXPECT_THAT(data->end_of_body_script, Eq("end_of_body_script")); |
| 265 } |
| 266 |
| 267 TEST_F(OneGoogleBarFetcherImplTest, CoalescesMultipleRequests) { |
| 268 // Trigger two requests. |
| 269 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> first_callback; |
| 270 one_google_bar_fetcher()->Fetch(first_callback.Get()); |
| 271 net::URLFetcher* first_fetcher = GetRunningURLFetcher(); |
| 272 base::MockCallback<OneGoogleBarFetcher::OneGoogleCallback> second_callback; |
| 273 one_google_bar_fetcher()->Fetch(second_callback.Get()); |
| 274 net::URLFetcher* second_fetcher = GetRunningURLFetcher(); |
| 275 |
| 276 // Expect that only one fetcher handles both requests. |
| 277 EXPECT_THAT(first_fetcher, Eq(second_fetcher)); |
| 278 |
| 279 // But both callbacks should get called. |
| 280 base::Optional<OneGoogleBarData> first_data; |
| 281 base::Optional<OneGoogleBarData> second_data; |
| 282 |
| 283 EXPECT_CALL(first_callback, Run(_)).WillOnce(SaveArg<0>(&first_data)); |
| 284 EXPECT_CALL(second_callback, Run(_)).WillOnce(SaveArg<0>(&second_data)); |
| 285 |
| 286 RespondWithData(kMinimalValidResponse); |
| 287 |
| 288 // Ensure that both requests received a response. |
| 289 EXPECT_TRUE(first_data.has_value()); |
| 290 EXPECT_TRUE(second_data.has_value()); |
| 291 } |
OLD | NEW |