Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: chrome/browser/search_engines/template_url_service_test_util.cc

Issue 2814743006: Refactoring after comments in https://codereview.chromium.org/2639153002 (Closed)
Patch Set: Fixed after review, round 2 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/template_url_service_test_util.cc
diff --git a/chrome/browser/search_engines/template_url_service_test_util.cc b/chrome/browser/search_engines/template_url_service_test_util.cc
index 722e2cc58d6cb3f6c68a197baf534cdb2f7b853c..aee657badda4cadf5cfdee42f61874d4f8a1e8c7 100644
--- a/chrome/browser/search_engines/template_url_service_test_util.cc
+++ b/chrome/browser/search_engines/template_url_service_test_util.cc
@@ -158,18 +158,11 @@ void TemplateURLServiceTestUtil::SetGoogleBaseURL(const GURL& base_url) {
}
TemplateURL* TemplateURLServiceTestUtil::AddExtensionControlledTURL(
- std::unique_ptr<TemplateURL> extension_turl,
- const std::string& extension_id,
- bool wants_to_be_default,
- base::Time install_time) {
- auto extension_info =
- base::MakeUnique<TemplateURL::AssociatedExtensionInfo>(extension_id);
- extension_info->wants_to_be_default_engine = wants_to_be_default;
- extension_info->install_time = install_time;
-
- TemplateURL* result = model()->AddExtensionControlledTURL(
- std::move(extension_turl), std::move(extension_info));
- if (wants_to_be_default && result) {
+ std::unique_ptr<TemplateURL> extension_turl) {
+ TemplateURL* result = model()->Add(std::move(extension_turl));
+ DCHECK(result);
+ DCHECK(result->GetExtensionInfoForTesting());
+ if (result->GetExtensionInfoForTesting()->wants_to_be_default_engine) {
SetExtensionDefaultSearchInPrefs(profile()->GetTestingPrefService(),
result->data());
}

Powered by Google App Engine
This is Rietveld 408576698