tools/metrics/histograms/histograms.xml - Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter.

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)

Patch Set: remove tests which are not neede anymore Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc ('K') | « components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index bb77eba52476897907043b3837095b1cd79525fd..06416a7d2b31a678487369c3f8b3dbfe332acb6a 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -70071,6 +70071,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="SubresourceFilter.PageLoad.Match" units="matches">

+ <owner>melandory@chromium.org</owner>

+ <summary>

+ Records the fact of a match of the last url in the redirect chain for the

+ main frame.

+ </summary>

+</histogram>

<histogram name="SubresourceFilter.PageLoad.NumSubresourceLoads.Disallowed"

units="resource loads">

<owner>pkalinnikov@chromium.org</owner>

@@ -70124,6 +70132,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

<histogram name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"

enum="SubresourceFilterMatchPattern">

+ <obsolete>

+ Obsolete, since the don't have correct data to record anymore.

engedy 2017/04/20 11:16:11 nit: Is Charlie planning to reinstate it in the fu

melandory 2017/04/25 13:48:14 Not quite following you. Given new strategy of che

engedy 2017/04/26 13:47:09 I think Charlie is changing that strategy back, bu

+ </obsolete>

<owner>melandory@chromium.org</owner>

For each main frame navigation, records a pattern that indicates which URLs

@@ -124878,13 +124889,12 @@ from previous Chrome versions.

</histogram_suffixes>

<histogram_suffixes name="SubresourceFilterOnlyExperiment" separator=".">

+ <affected-histogram name="SubresourceFilter.PageLoad.Match"/>

+ <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/>

<suffix name="SocialEngineeringAdsInterstitial"

label="social eng ad blacklist pattern"/>

- <suffix name="SubresourceFilterOnly" label="subresource filter only patern"/>

- <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/>

- <affected-histogram

- name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"/>

+ <suffix name="SubresourceFilterOnly" label="subresource filter only pattern"/>

</histogram_suffixes>

<histogram_suffixes name="SyncModelType" separator=".">