components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h - Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)

Patch Set: remove tests which are not neede anymore Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_local_database_manager.cc ('K') | « components/safe_browsing_db/v4_local_database_manager.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('j') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

index 7577274e45f77a54e02a31cd4dcea1a74e67f0c9..c61f1245fae6bbf6983e206340973a090676df33 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

@@ -165,8 +165,7 @@ class ContentSubresourceFilterDriverFactory

ActivationList activation_list) const;

void AddActivationListMatch(const GURL& url, ActivationList match_type);

- int CalculateHitPatternForActivationList(

- ActivationList activation_list) const;

+ bool CalculateMatchForActivationList(ActivationList activation_list) const;

void RecordRedirectChainMatchPattern() const;

void RecordRedirectChainMatchPatternForList(