components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h - Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)

Patch Set: rebased and changes sync strategy Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/v4_database.cc ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc ('k') | components/subresource_filter/content/browser/fake_safe_browsing_database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

diff --git a/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h b/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

index f36c437d4ba1b1bf294b6fa08569440b20cbd65d..693ab5292ae05d2395534425c76ad6da209ae9e3 100644

--- a/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

+++ b/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h

@@ -22,7 +22,9 @@ class FakeSafeBrowsingDatabaseManager

FakeSafeBrowsingDatabaseManager();

void AddBlacklistedUrl(const GURL& url,

- safe_browsing::SBThreatType threat_type);

+ safe_browsing::SBThreatType threat_type,

+ safe_browsing::ThreatPatternType pattern_type =

+ safe_browsing::ThreatPatternType::NONE);

void SimulateTimeout();

@@ -44,8 +46,11 @@ class FakeSafeBrowsingDatabaseManager

private:

void OnCheckUrlForSubresourceFilterComplete(Client* client, const GURL& url);

- std::map<GURL, safe_browsing::SBThreatType> url_to_threat_type_;

std::set<Client*> checks_;

+ std::map<

+ GURL,

+ std::pair<safe_browsing::SBThreatType, safe_browsing::ThreatPatternType>>

+ url_to_threat_type_;

bool simulate_timeout_;

DISALLOW_COPY_AND_ASSIGN(FakeSafeBrowsingDatabaseManager);