components/safe_browsing_db/v4_local_database_manager.cc - Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_local_database_manager.cc

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)

Patch Set: rebased and changes sync strategy Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/v4_local_database_manager.cc

diff --git a/components/safe_browsing_db/v4_local_database_manager.cc b/components/safe_browsing_db/v4_local_database_manager.cc

index 6644f662d80677a734ce471c54363ed0581dfd88..1b547f62db7847ea8940011f1b0cd717ad1b481d 100644

--- a/components/safe_browsing_db/v4_local_database_manager.cc

+++ b/components/safe_browsing_db/v4_local_database_manager.cc

@@ -276,7 +276,8 @@ bool V4LocalDatabaseManager::CheckUrlForSubresourceFilter(const GURL& url,

Client* client) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

- StoresToCheck stores_to_check({GetUrlSubresourceFilterId()});

+ StoresToCheck stores_to_check(

+ {GetUrlSocEngId(), GetUrlSubresourceFilterId()});

if (!AreStoresAvailableNow(stores_to_check) || !CanCheckUrl(url)) {

return true;

}