Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: components/safe_browsing_db/v4_local_database_manager.cc

Issue 2814733002: Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_local_database_manager.cc
diff --git a/components/safe_browsing_db/v4_local_database_manager.cc b/components/safe_browsing_db/v4_local_database_manager.cc
index 6644f662d80677a734ce471c54363ed0581dfd88..51ca827ee8e4a1e116bdf8db93c4769eecda967f 100644
--- a/components/safe_browsing_db/v4_local_database_manager.cc
+++ b/components/safe_browsing_db/v4_local_database_manager.cc
@@ -74,7 +74,7 @@ ListInfos GetListInfos() {
GetChromeUrlClientIncidentId(),
SB_THREAT_TYPE_BLACKLISTED_RESOURCE),
ListInfo(kSyncNever, "", GetChromeUrlApiId(), SB_THREAT_TYPE_API_ABUSE),
- ListInfo(kSyncOnlyOnChromeBuilds, "UrlSubresourceFilter.store",
+ ListInfo(kSyncAlways, "UrlSubresourceFilter.store",
engedy 2017/04/26 13:47:09 Would this allow us to re-enable the browsertests
melandory 2017/04/26 15:02:20 Yes!
GetUrlSubresourceFilterId(), SB_THREAT_TYPE_SUBRESOURCE_FILTER),
});
// NOTE(vakh): IMPORTANT: Please make sure that the server already supports
@@ -276,7 +276,8 @@ bool V4LocalDatabaseManager::CheckUrlForSubresourceFilter(const GURL& url,
Client* client) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
- StoresToCheck stores_to_check({GetUrlSubresourceFilterId()});
+ StoresToCheck stores_to_check(
+ {GetUrlSocEngId(), GetUrlSubresourceFilterId()});
if (!AreStoresAvailableNow(stores_to_check) || !CanCheckUrl(url)) {
return true;
}

Powered by Google App Engine
This is Rietveld 408576698