Chromium Code Reviews Chromium Code Reviews
Issue 2814733002:
Add the SocEng as a type for checking in CheckUrlForSubresourceFilter. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index cb4d84f193dce7c28ce4ce179d3e1b0630bf46f7..50f152ac899282f3dc4f6379e3769f7d5e4ea851 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -70926,6 +70926,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="SubresourceFilter.PageLoad.RedirectChainMatchPattern" |
| enum="SubresourceFilterMatchPattern"> |
| + <obsolete> |
| + Obsolete, since the don't have correct data to record anymore. |
|
jwd
2017/04/26 23:34:10
Can you add the year and month when it is being ob
melandory
2017/04/27 17:10:13
Done.
|
| + </obsolete> |
| <owner>melandory@chromium.org</owner> |
| <summary> |
| For each main frame navigation, records a pattern that indicates which URLs |
| @@ -71021,6 +71024,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="SubresourecFilter.PageLoad.FinalURLMatch" units="matches"> |
| + <owner>melandory@chromium.org</owner> |
| + <summary> |
| + Records, for each main frame navigation, whether the last URL in |
| + the redirect chain matched the Safe Browsing blacklist specified by the |
| + histogram suffix. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Suggestions.FailedRequestErrorCode" enum="NetErrorCodes"> |
| <owner>mathp@chromium.org</owner> |
| <summary> |
| @@ -127168,13 +127180,12 @@ from previous Chrome versions. |
| </histogram_suffixes> |
| <histogram_suffixes name="SubresourceFilterOnlyExperiment" separator="."> |
| + <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/> |
| <suffix name="SocialEngineeringAdsInterstitial" |
| label="social eng ad blacklist pattern"/> |
| <suffix name="PhishingInterstitial" label="phishing blacklist pattern"/> |
| - <suffix name="SubresourceFilterOnly" label="subresource filter only patern"/> |
|
jwd
2017/04/26 23:34:10
Rather than delete, add an obsolete child tag. Sam
melandory
2017/04/27 17:10:12
Hm, this line is not deleted, just type was fixed.
|
| - <affected-histogram name="SubresourceFilter.PageLoad.RedirectChainLength"/> |
| - <affected-histogram |
| - name="SubresourceFilter.PageLoad.RedirectChainMatchPattern"/> |
| + <suffix name="SubresourceFilterOnly" label="subresource filter only pattern"/> |
| + <affected-histogram name="SubresourecFilter.PageLoad.FinalURLMatch"/> |
| </histogram_suffixes> |
| <histogram_suffixes name="SyncModelType" separator="."> |
