src/objects-inl.h - Issue 2814683002: [builtins] Implement %TypedArray%.prototype.map in the CSA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 2814683002: [builtins] Implement %TypedArray%.prototype.map in the CSA (Closed)

Patch Set: switched to BIND macro Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 04e0511a57846fcda7a9734c8c49c4cf06fa1f1d..0a38433c8f6076bd857b69eb369fe2e353e5ccb4 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -6920,8 +6920,7 @@ void JSTypedArray::set_length(Object* value, WriteBarrierMode mode) {

// static

MaybeHandle<JSTypedArray> JSTypedArray::Validate(Isolate* isolate,

- Handle<Object> receiver,

- const char* method_name) {

+ Handle<Object> receiver) {

danno 2017/04/24 16:11:16 Nice cleanup.

if (V8_UNLIKELY(!receiver->IsJSTypedArray())) {

const MessageTemplate::Template message = MessageTemplate::kNotTypedArray;

THROW_NEW_ERROR(isolate, NewTypeError(message), JSTypedArray);