Use ClassEntity in ClassHierarchyNode

Use ClassEntity in ClassHierarchyNode

This makes ClassSet/ClassHierachyNode reusable for kernel based elements.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/f900cf69b776fbe9137a0c2e9678af23a25fb298

[Johnni Winther, 2017-04-11 08:36:52]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-04-11 19:45:48]

lgtm

https://codereview.chromium.org/2814663002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/class_set.dart (right):

https://codereview.chromium.org/2814663002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/class_set.dart:205:
ClassHierarchyNode(this.parentNode, this.cls, this.hierarchyDepth) {
why not make a getter for hierarchyDepth:

int get hierarchyDepth => cls.hierarchyDepth;

rather than needing to pass in more information to the constructor?

[Johnni Winther, 2017-04-12 07:19:29]

https://codereview.chromium.org/2814663002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/class_set.dart (right):

https://codereview.chromium.org/2814663002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/class_set.dart:205:
ClassHierarchyNode(this.parentNode, this.cls, this.hierarchyDepth) {
On 2017/04/11 19:45:48, Emily Fortuna wrote:
> why not make a getter for hierarchyDepth:
> 
> int get hierarchyDepth => cls.hierarchyDepth;
> 
> rather than needing to pass in more information to the constructor?

Because ClassEntity doesn't have a .hierarchyDepth and I'm reluctant to add it.
This is part of avoiding the need for it.

[Johnni Winther, 2017-04-12 07:23:55]

Description was changed from

==========
Use ClassEntity in ClassHierarchyNode

This makes ClassSet/ClassHierachyNode reusable for kernel based elements.
==========

to

==========
Use ClassEntity in ClassHierarchyNode

This makes ClassSet/ClassHierachyNode reusable for kernel based elements.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f900cf69b776fbe9137a0c2e9678af23a25fb298
==========

[Johnni Winther, 2017-04-12 07:23:57]

Committed patchset #1 (id:1) manually as
f900cf69b776fbe9137a0c2e9678af23a25fb298 (presubmit successful).