Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutPart.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Address final comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutPart.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.h b/third_party/WebKit/Source/core/layout/LayoutPart.h
index 0a42bcde8492917be84502be29c512b7da39d35f..f34be6d49115bb6701e31befc2b1f717ee119d85 100644
--- a/third_party/WebKit/Source/core/layout/LayoutPart.h
+++ b/third_party/WebKit/Source/core/layout/LayoutPart.h
@@ -25,11 +25,12 @@
#include "core/CoreExport.h"
#include "core/layout/LayoutReplaced.h"
-#include "core/plugins/PluginView.h"
-#include "platform/FrameViewBase.h"
namespace blink {
+class FrameOrPlugin;
+class PluginView;
+
// LayoutObject for frames via LayoutFrame and LayoutIFrame, and plugins via
// LayoutEmbeddedObject.
class CORE_EXPORT LayoutPart : public LayoutReplaced {
@@ -55,7 +56,7 @@ class CORE_EXPORT LayoutPart : public LayoutReplaced {
// the FrameView associated with the root Document Frame.
FrameView* ChildFrameView() const;
PluginView* Plugin() const;
- FrameViewBase* PluginOrFrame() const;
+ FrameOrPlugin* GetFrameOrPlugin() const;
LayoutRect ReplacedContentRect() const final;
@@ -80,7 +81,7 @@ class CORE_EXPORT LayoutPart : public LayoutReplaced {
const PaintInvalidationState&) override;
private:
- void UpdateGeometryInternal(FrameViewBase&);
+ void UpdateGeometryInternal(FrameOrPlugin&);
CompositingReasons AdditionalCompositingReasons() const override;
void WillBeDestroyed() final;
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutPart.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698