Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Address final comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
index 43fe90a468fa8d032dbd1dc233a9ef1835a7d6af..3665ea9f8012823b4c414f5cd681d9e21f9d00fc 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
@@ -104,7 +104,7 @@ void HTMLPlugInElement::SetPlugin(PluginView* plugin) {
// Remove and dispose the old plugin if we had one.
if (plugin_) {
GetDocument().View()->RemovePlugin(plugin_);
- DisposeWidgetSoon(plugin_);
+ DisposeFrameOrPluginSoon(plugin_);
}
plugin_ = plugin;
@@ -150,7 +150,7 @@ void HTMLPlugInElement::SetPersistedPlugin(PluginView* plugin) {
return;
if (persisted_plugin_) {
persisted_plugin_->Hide();
- DisposeWidgetSoon(persisted_plugin_.Release());
+ DisposeFrameOrPluginSoon(persisted_plugin_.Release());
}
persisted_plugin_ = plugin;
}

Powered by Google App Engine
This is Rietveld 408576698