Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: third_party/WebKit/Source/core/frame/RemoteFrameView.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Address final comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/RemoteFrameView.h
diff --git a/third_party/WebKit/Source/core/frame/RemoteFrameView.h b/third_party/WebKit/Source/core/frame/RemoteFrameView.h
index 3a1f93d5d18debe5d46bcccdd143ac20389d5cbe..886ec9a3d63e85ca2d5dee5f8dcd5e6df63e1fa9 100644
--- a/third_party/WebKit/Source/core/frame/RemoteFrameView.h
+++ b/third_party/WebKit/Source/core/frame/RemoteFrameView.h
@@ -5,15 +5,20 @@
#ifndef RemoteFrameView_h
#define RemoteFrameView_h
+#include "core/frame/FrameOrPlugin.h"
#include "platform/FrameViewBase.h"
#include "platform/geometry/IntRect.h"
#include "platform/heap/Handle.h"
namespace blink {
+class CullRect;
+class GraphicsContext;
class RemoteFrame;
-class RemoteFrameView final : public FrameViewBase {
+class RemoteFrameView final : public FrameViewBase, public FrameOrPlugin {
+ USING_GARBAGE_COLLECTED_MIXIN(RemoteFrameView);
+
public:
static RemoteFrameView* Create(RemoteFrame*);
@@ -30,8 +35,12 @@ class RemoteFrameView final : public FrameViewBase {
void Dispose() override;
// Override to notify remote frame that its viewport size has changed.
void FrameRectsChanged() override;
- void InvalidateRect(const IntRect&) override;
+ void InvalidateRect(const IntRect&);
void SetFrameRect(const IntRect&) override;
+ const IntRect& FrameRect() const override {
+ return FrameViewBase::FrameRect();
+ }
+ void Paint(GraphicsContext&, const CullRect&) const override {}
void Hide() override;
void Show() override;
void SetParentVisible(bool) override;
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/frame/RemoteFrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698