Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Merge after dependency CL Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
index 2bda3b5c68f68642b59bda16d9d5817a261636f0..6ea10150aacefe04ab0956e71bc4e044433f381b 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h
@@ -34,6 +34,7 @@ namespace blink {
class ExceptionState;
class Frame;
+class FrameOrPlugin;
class FrameViewBase;
class LayoutPart;
@@ -105,7 +106,7 @@ class CORE_EXPORT HTMLFrameOwnerElement : public HTMLElement,
bool replace_current_item);
bool IsKeyboardFocusable() const override;
- void DisposeWidgetSoon(FrameViewBase*);
+ void DisposeSoon(FrameOrPlugin*);
dcheng 2017/04/17 21:09:04 Let's fix the naming for this method, since we're
joelhockey 2017/04/18 00:42:41 I have renamed the method to DisposeFrameOrPluginS
dcheng 2017/04/18 00:56:31 I think we should implement haraken's suggested na
void FrameOwnerPropertiesChanged();
private:

Powered by Google App Engine
This is Rietveld 408576698