Remove FrameViewBase as base class of PluginView.

third_party/WebKit/Source/core/frame/FrameOrPlugin.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef FrameOrPlugin_h
+#define FrameOrPlugin_h
+
+#include "core/CoreExport.h"
+
+namespace blink {
+
+class CullRect;
+class GraphicsContext;
+class IntRect;
+
+class CORE_EXPORT FrameOrPlugin {

[dcheng, 2017/04/12 00:06:39]

My personal feeling about this naming is that it's too directly tied to the
subclasses and doesn't really describe what this interface is for (it's for
common functionality, but what is the common functionality? Is there something
we could name it that would better reflect its purpose? Etc)

It's kind of hard to name though... but I think we should try to figure
something out here.

[joelhockey, 2017/04/12 04:33:00]

I totally agree that it is better to name based on what the thing does, not on
what the things are that implement it, but I went with FrameOrPlugin since it
was the best of the options I could think of.

So what does this do?:
It has methods: SetFrameRect, FrameRect, Paint, Hide, Show, Dispose.

Suggestions:
* View - I had this one first, but the word View is too general and becomes very
confusing since we already have a lot of methods named View that return
LayoutView or FrameView or some other views.
* VisibleRectangle or FrameRect or FrameRectangle - this seems to describe what
the thing is based on the methods that it has.
* FrameView - rename existing FrameView to LocalFrameView.  This makes sense
since we also have RemoteFrameView.
* FrameViewInterface
* FrameViewBase - once existing FrameViewBase (old Widget) class is removed,
then I could change FrameOrPlugin to be FrameViewBase.
* Widget - ha, ha, this is a joke.  But it goes to show that Widget is not a
crazy name for this thing.

[haraken, 2017/04/12 06:32:31]

Add a class-level comment.

[joelhockey, 2017/04/13 05:42:30]

Done

+ public:
+  // FrameOrPlugin();

[haraken, 2017/04/12 06:32:31]

Remove this?

[joelhockey, 2017/04/13 05:42:30]

Done

+  virtual ~FrameOrPlugin() {}
+
+  virtual void SetFrameRect(const IntRect& frameRect) = 0;
+  virtual const IntRect& FrameRect() const = 0;
+  virtual void Paint(GraphicsContext&, const CullRect&) const = 0;
+  virtual void Show() = 0;
+  virtual void Hide() = 0;
+  virtual void Dispose() = 0;
+};
+
+}  // namespace blink
+#endif  // FrameOrPlugin_h