Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2814643003: Remove FrameViewBase as base class of PluginView. (Closed)
Patch Set: Address final comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
8 reserved. 8 reserved.
9 9
10 This library is free software; you can redistribute it and/or 10 This library is free software; you can redistribute it and/or
(...skipping 11 matching lines...) Expand all
22 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 22 the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
23 Boston, MA 02110-1301, USA. 23 Boston, MA 02110-1301, USA.
24 */ 24 */
25 25
26 #ifndef FrameView_h 26 #ifndef FrameView_h
27 #define FrameView_h 27 #define FrameView_h
28 28
29 #include <memory> 29 #include <memory>
30 #include "core/CoreExport.h" 30 #include "core/CoreExport.h"
31 #include "core/dom/DocumentLifecycle.h" 31 #include "core/dom/DocumentLifecycle.h"
32 #include "core/frame/FrameOrPlugin.h"
32 #include "core/frame/FrameViewAutoSizeInfo.h" 33 #include "core/frame/FrameViewAutoSizeInfo.h"
33 #include "core/frame/LayoutSubtreeRootList.h" 34 #include "core/frame/LayoutSubtreeRootList.h"
34 #include "core/frame/RootFrameViewport.h" 35 #include "core/frame/RootFrameViewport.h"
35 #include "core/layout/MapCoordinatesFlags.h" 36 #include "core/layout/MapCoordinatesFlags.h"
36 #include "core/layout/ScrollAnchor.h" 37 #include "core/layout/ScrollAnchor.h"
37 #include "core/paint/FirstMeaningfulPaintDetector.h" 38 #include "core/paint/FirstMeaningfulPaintDetector.h"
38 #include "core/paint/ObjectPaintProperties.h" 39 #include "core/paint/ObjectPaintProperties.h"
39 #include "core/paint/PaintInvalidationCapableScrollableArea.h" 40 #include "core/paint/PaintInvalidationCapableScrollableArea.h"
40 #include "core/paint/PaintPhase.h" 41 #include "core/paint/PaintPhase.h"
41 #include "core/paint/ScrollbarManager.h" 42 #include "core/paint/ScrollbarManager.h"
(...skipping 22 matching lines...) Expand all
64 namespace blink { 65 namespace blink {
65 66
66 class AXObjectCache; 67 class AXObjectCache;
67 class ComputedStyle; 68 class ComputedStyle;
68 class Cursor; 69 class Cursor;
69 class DocumentLifecycle; 70 class DocumentLifecycle;
70 class Element; 71 class Element;
71 class ElementVisibilityObserver; 72 class ElementVisibilityObserver;
72 class Frame; 73 class Frame;
73 class FloatSize; 74 class FloatSize;
75 class IntRect;
74 class JSONArray; 76 class JSONArray;
75 class JSONObject; 77 class JSONObject;
76 class LayoutItem; 78 class LayoutItem;
77 class LayoutViewItem; 79 class LayoutViewItem;
78 class LayoutPart; 80 class LayoutPart;
79 class LocalFrame; 81 class LocalFrame;
80 class KURL; 82 class KURL;
81 class Node; 83 class Node;
82 class LayoutAnalyzer; 84 class LayoutAnalyzer;
83 class LayoutBox; 85 class LayoutBox;
(...skipping 10 matching lines...) Expand all
94 class ScrollingCoordinator; 96 class ScrollingCoordinator;
95 class TracedValue; 97 class TracedValue;
96 class TransformState; 98 class TransformState;
97 struct AnnotatedRegionValue; 99 struct AnnotatedRegionValue;
98 struct CompositedSelection; 100 struct CompositedSelection;
99 101
100 typedef unsigned long long DOMTimeStamp; 102 typedef unsigned long long DOMTimeStamp;
101 103
102 class CORE_EXPORT FrameView final 104 class CORE_EXPORT FrameView final
103 : public FrameViewBase, 105 : public FrameViewBase,
106 public FrameOrPlugin,
104 public PaintInvalidationCapableScrollableArea { 107 public PaintInvalidationCapableScrollableArea {
105 USING_GARBAGE_COLLECTED_MIXIN(FrameView); 108 USING_GARBAGE_COLLECTED_MIXIN(FrameView);
106 109
107 friend class PaintControllerPaintTestBase; 110 friend class PaintControllerPaintTestBase;
108 friend class Internals; 111 friend class Internals;
109 friend class LayoutPart; // for invalidateTreeIfNeeded 112 friend class LayoutPart; // for invalidateTreeIfNeeded
110 113
111 public: 114 public:
112 static FrameView* Create(LocalFrame&); 115 static FrameView* Create(LocalFrame&);
113 static FrameView* Create(LocalFrame&, const IntSize& initial_size); 116 static FrameView* Create(LocalFrame&, const IntSize& initial_size);
114 117
115 ~FrameView() override; 118 ~FrameView() override;
116 119
117 void InvalidateRect(const IntRect&) override; 120 void Invalidate() { InvalidateRect(IntRect(0, 0, Width(), Height())); }
121 void InvalidateRect(const IntRect&);
118 void SetFrameRect(const IntRect&) override; 122 void SetFrameRect(const IntRect&) override;
123 const IntRect& FrameRect() const override {
124 return FrameViewBase::FrameRect();
125 }
119 126
120 LocalFrame& GetFrame() const { 127 LocalFrame& GetFrame() const {
121 ASSERT(frame_); 128 ASSERT(frame_);
122 return *frame_; 129 return *frame_;
123 } 130 }
124 131
125 Page* GetPage() const; 132 Page* GetPage() const;
126 133
127 // TODO(pilgrim) replace all instances of layoutView() with layoutViewItem() 134 // TODO(pilgrim) replace all instances of layoutView() with layoutViewItem()
128 // https://crbug.com/499321 135 // https://crbug.com/499321
(...skipping 1130 matching lines...) Expand 10 before | Expand all | Expand 10 after
1259 frameViewBase.IsFrameView()); 1266 frameViewBase.IsFrameView());
1260 DEFINE_TYPE_CASTS(FrameView, 1267 DEFINE_TYPE_CASTS(FrameView,
1261 ScrollableArea, 1268 ScrollableArea,
1262 scrollableArea, 1269 scrollableArea,
1263 scrollableArea->IsFrameView(), 1270 scrollableArea->IsFrameView(),
1264 scrollableArea.IsFrameView()); 1271 scrollableArea.IsFrameView());
1265 1272
1266 } // namespace blink 1273 } // namespace blink
1267 1274
1268 #endif // FrameView_h 1275 #endif // FrameView_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameOrPlugin.h ('k') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698