Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: net/http/http_stream_factory_test_util.h

Issue 2814633003: Extract Proxy Resolution out of HttpStreamFactoryImpl::Job (Closed)
Patch Set: fix alt proxy tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_test_util.h
diff --git a/net/http/http_stream_factory_test_util.h b/net/http/http_stream_factory_test_util.h
index a8de702be927456d9d3cb1b36c7e2596b06cb1bb..e2ee017934bfa5c1062d6c3eea1d5f3d57c99482 100644
--- a/net/http/http_stream_factory_test_util.h
+++ b/net/http/http_stream_factory_test_util.h
@@ -97,6 +97,7 @@ class MockHttpStreamFactoryImplJob : public HttpStreamFactoryImpl::Job {
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -109,6 +110,7 @@ class MockHttpStreamFactoryImplJob : public HttpStreamFactoryImpl::Job {
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -131,12 +133,13 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {
TestJobFactory();
~TestJobFactory() override;
- HttpStreamFactoryImpl::Job* CreateJob(
+ HttpStreamFactoryImpl::Job* CreateMainJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
HttpStreamFactoryImpl::JobType job_type,
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -144,12 +147,13 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {
bool enable_ip_based_pooling,
NetLog* net_log) override;
- HttpStreamFactoryImpl::Job* CreateJob(
+ HttpStreamFactoryImpl::Job* CreateAltJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
HttpStreamFactoryImpl::JobType job_type,
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -158,12 +162,13 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {
bool enable_ip_based_pooling,
NetLog* net_log) override;
- HttpStreamFactoryImpl::Job* CreateJob(
+ HttpStreamFactoryImpl::Job* CreateAltProxyJob(
HttpStreamFactoryImpl::Job::Delegate* delegate,
HttpStreamFactoryImpl::JobType job_type,
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,

Powered by Google App Engine
This is Rietveld 408576698