Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: net/http/http_stream_factory_test_util.cc

Issue 2814633003: Extract Proxy Resolution out of HttpStreamFactoryImpl::Job (Closed)
Patch Set: add one more test for ReconsiderProxyAfterError Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_test_util.cc
diff --git a/net/http/http_stream_factory_test_util.cc b/net/http/http_stream_factory_test_util.cc
index 55fb736e568db1042749cc56fb1a205976fb62f4..e733b9c733e66319dd90181ca0e0a9ad98f3fc3a 100644
--- a/net/http/http_stream_factory_test_util.cc
+++ b/net/http/http_stream_factory_test_util.cc
@@ -19,6 +19,7 @@ MockHttpStreamFactoryImplJob::MockHttpStreamFactoryImplJob(
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -30,6 +31,7 @@ MockHttpStreamFactoryImplJob::MockHttpStreamFactoryImplJob(
session,
request_info,
priority,
+ proxy_info,
server_ssl_config,
proxy_ssl_config,
destination,
@@ -45,6 +47,7 @@ MockHttpStreamFactoryImplJob::MockHttpStreamFactoryImplJob(
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -58,6 +61,7 @@ MockHttpStreamFactoryImplJob::MockHttpStreamFactoryImplJob(
session,
request_info,
priority,
+ proxy_info,
server_ssl_config,
proxy_ssl_config,
destination,
@@ -82,20 +86,20 @@ HttpStreamFactoryImpl::Job* TestJobFactory::CreateJob(
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
GURL origin_url,
bool enable_ip_based_pooling,
NetLog* net_log) {
- DCHECK(!main_job_);
-
if (override_main_job_url_)
origin_url = main_job_alternative_url_;
main_job_ = new MockHttpStreamFactoryImplJob(
- delegate, job_type, session, request_info, priority, SSLConfig(),
- SSLConfig(), destination, origin_url, enable_ip_based_pooling, nullptr);
+ delegate, job_type, session, request_info, priority, proxy_info,
+ SSLConfig(), SSLConfig(), destination, origin_url,
+ enable_ip_based_pooling, nullptr);
return main_job_;
}
@@ -106,6 +110,7 @@ HttpStreamFactoryImpl::Job* TestJobFactory::CreateJob(
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -113,11 +118,10 @@ HttpStreamFactoryImpl::Job* TestJobFactory::CreateJob(
AlternativeService alternative_service,
bool enable_ip_based_pooling,
NetLog* net_log) {
- DCHECK(!alternative_job_);
alternative_job_ = new MockHttpStreamFactoryImplJob(
- delegate, job_type, session, request_info, priority, SSLConfig(),
- SSLConfig(), destination, origin_url, alternative_service, ProxyServer(),
- enable_ip_based_pooling, nullptr);
+ delegate, job_type, session, request_info, priority, proxy_info,
+ SSLConfig(), SSLConfig(), destination, origin_url, alternative_service,
+ ProxyServer(), enable_ip_based_pooling, nullptr);
return alternative_job_;
}
@@ -128,6 +132,7 @@ HttpStreamFactoryImpl::Job* TestJobFactory::CreateJob(
HttpNetworkSession* session,
const HttpRequestInfo& request_info,
RequestPriority priority,
+ ProxyInfo proxy_info,
const SSLConfig& server_ssl_config,
const SSLConfig& proxy_ssl_config,
HostPortPair destination,
@@ -135,10 +140,9 @@ HttpStreamFactoryImpl::Job* TestJobFactory::CreateJob(
const ProxyServer& alternative_proxy_server,
bool enable_ip_based_pooling,
NetLog* net_log) {
- DCHECK(!alternative_job_);
alternative_job_ = new MockHttpStreamFactoryImplJob(
- delegate, job_type, session, request_info, priority, SSLConfig(),
- SSLConfig(), destination, origin_url, AlternativeService(),
+ delegate, job_type, session, request_info, priority, proxy_info,
+ SSLConfig(), SSLConfig(), destination, origin_url, AlternativeService(),
alternative_proxy_server, enable_ip_based_pooling, nullptr);
return alternative_job_;

Powered by Google App Engine
This is Rietveld 408576698