net/http/http_stream_factory_test_util.h - Issue 2814633003: Extract Proxy Resolution out of HttpStreamFactoryImpl::Job

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_test_util.h

Issue 2814633003: Extract Proxy Resolution out of HttpStreamFactoryImpl::Job (Closed)

Patch Set: fix remaining tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_stream_factory_impl_job_controller_unittest.cc ('K') | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/http/http_stream_factory_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_stream_factory_test_util.h

diff --git a/net/http/http_stream_factory_test_util.h b/net/http/http_stream_factory_test_util.h

index a8de702be927456d9d3cb1b36c7e2596b06cb1bb..512d5376f82240d443ca6e1a08d53a938101fc3f 100644

--- a/net/http/http_stream_factory_test_util.h

+++ b/net/http/http_stream_factory_test_util.h

@@ -97,6 +97,7 @@ class MockHttpStreamFactoryImplJob : public HttpStreamFactoryImpl::Job {

HttpNetworkSession* session,

const HttpRequestInfo& request_info,

RequestPriority priority,

+ ProxyInfo proxy_info,

const SSLConfig& server_ssl_config,

const SSLConfig& proxy_ssl_config,

HostPortPair destination,

@@ -109,6 +110,7 @@ class MockHttpStreamFactoryImplJob : public HttpStreamFactoryImpl::Job {

HttpNetworkSession* session,

const HttpRequestInfo& request_info,

RequestPriority priority,

+ ProxyInfo proxy_info,

const SSLConfig& server_ssl_config,

const SSLConfig& proxy_ssl_config,

HostPortPair destination,

@@ -137,6 +139,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {

HttpNetworkSession* session,

const HttpRequestInfo& request_info,

RequestPriority priority,

+ ProxyInfo proxy_info,

const SSLConfig& server_ssl_config,

const SSLConfig& proxy_ssl_config,

HostPortPair destination,

@@ -150,6 +153,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {

HttpNetworkSession* session,

const HttpRequestInfo& request_info,

RequestPriority priority,

+ ProxyInfo proxy_info,

const SSLConfig& server_ssl_config,

const SSLConfig& proxy_ssl_config,

HostPortPair destination,

@@ -164,6 +168,7 @@ class TestJobFactory : public HttpStreamFactoryImpl::JobFactory {

HttpNetworkSession* session,

const HttpRequestInfo& request_info,

RequestPriority priority,

+ ProxyInfo proxy_info,

const SSLConfig& server_ssl_config,

const SSLConfig& proxy_ssl_config,

HostPortPair destination,