Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2294)

Unified Diff: chrome/browser/chromeos/printing/printer_configurer.cc

Issue 2814633002: Add CupsFilter extraction from resolved ppds for printing. (Closed)
Patch Set: Address skau@ comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/printing/printer_configurer.cc
diff --git a/chrome/browser/chromeos/printing/printer_configurer.cc b/chrome/browser/chromeos/printing/printer_configurer.cc
index f2f2e02a06426692186d3e3dafe35cfa7df2033a..a7c812b84ba348ea0097c210bac4ab44ac8b8d4b 100644
--- a/chrome/browser/chromeos/printing/printer_configurer.cc
+++ b/chrome/browser/chromeos/printing/printer_configurer.cc
@@ -6,6 +6,7 @@
#include <memory>
#include <string>
+#include <vector>
#include "base/bind.h"
#include "base/callback.h"
@@ -119,7 +120,10 @@ class PrinterConfigurerImpl : public PrinterConfigurer {
void ResolvePpdDone(const Printer& printer,
const PrinterSetupCallback& cb,
printing::PpdProvider::CallbackResultCode result,
- const std::string& ppd_contents) {
+ const std::string& ppd_contents,
+ const std::vector<std::string>& ppd_filters) {
+ // TODO(justincarlson) - Use ppd_filters to invoke cups components downloads
+ // if needed.
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
switch (result) {
case chromeos::printing::PpdProvider::SUCCESS:
« no previous file with comments | « no previous file | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698