third_party/WebKit/Source/core/dom/NodeRareData.cpp - Issue 2814603002: Move LayoutObject to satellite NodeLayoutData that hangs from a Node.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/NodeRareData.cpp

Issue 2814603002: Move LayoutObject to satellite NodeLayoutData that hangs from a Node. (Closed)

Patch Set: Review's comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/NodeRareData.cpp

diff --git a/third_party/WebKit/Source/core/dom/NodeRareData.cpp b/third_party/WebKit/Source/core/dom/NodeRareData.cpp

index 221b9ca6d06193cbaa22f92b5ea82c8f3b572d6f..c51efd99fdd94f3e057d6e8e01457901cf4326a1 100644

--- a/third_party/WebKit/Source/core/dom/NodeRareData.cpp

+++ b/third_party/WebKit/Source/core/dom/NodeRareData.cpp

@@ -77,7 +77,7 @@ DEFINE_TRACE_WRAPPERS_AFTER_DISPATCH(NodeRareData) {

}

void NodeRareData::FinalizeGarbageCollectedObject() {

- CHECK(!GetLayoutObject());

+ CHECK(!GetNodeLayoutData()->GetLayoutObject());

esprehn 2017/04/13 18:41:08 Can we put this in the destructor of NodeLayoutDat

nainar 2017/04/13 20:21:03 Done.

if (is_element_rare_data_)

static_cast<ElementRareData*>(this)->~ElementRareData();

else