Move LayoutObject to satellite NodeLayoutData that hangs from a Node.

third_party/WebKit/Source/core/dom/Node.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  *
@@ skipping 279 matching lines @@
   DCHECK(tree_scope_ || type == kCreateDocument || type == kCreateShadowRoot);
 #if !defined(NDEBUG) || (defined(DUMP_NODE_STATISTICS) && DUMP_NODE_STATISTICS)
   TrackForDebugging();
 #endif
   InstanceCounters::IncrementNodeCounter();
 }
 
 Node::~Node() {
   // With Oilpan, the rare data finalizer also asserts for
   // this condition (we cannot directly access it here.)
   CHECK(HasRareData() || !GetLayoutObject());

[esprehn, 2017/04/13 22:02:49]

You can remove this CHECK and the comment now, the assert is handled inside
~NodeLayoutData.

[nainar, 2017/04/13 22:28:16]

Done.

+  if (!HasRareData() && !data_.node_layout_data_->IsSharedEmptyData())
+    delete data_.node_layout_data_;
   InstanceCounters::DecrementNodeCounter();
 }
 
 NodeRareData* Node::RareData() const {
   SECURITY_DCHECK(HasRareData());
   return static_cast<NodeRareData*>(data_.rare_data_);
 }
 
 NodeRareData& Node::EnsureRareData() {
   if (HasRareData())
     return *RareData();
 
   if (IsElementNode())
-    data_.rare_data_ = ElementRareData::Create(data_.layout_object_);
+    data_.rare_data_ = ElementRareData::Create(data_.node_layout_data_);
   else
-    data_.rare_data_ = NodeRareData::Create(data_.layout_object_);
+    data_.rare_data_ = NodeRareData::Create(data_.node_layout_data_);
 
   DCHECK(data_.rare_data_);
   SetFlag(kHasRareDataFlag);
   ScriptWrappableVisitor::WriteBarrier(this, RareData());
   return *RareData();
 }
 
 Node* Node::ToNode() {
   return this;
 }
@@ skipping 255 matching lines @@
       node = NodeTraversal::NextPostOrder(*node);
   }
 }
 
 LayoutBox* Node::GetLayoutBox() const {
   LayoutObject* layout_object = this->GetLayoutObject();
   return layout_object && layout_object->IsBox() ? ToLayoutBox(layout_object)
                                                  : nullptr;
 }
 
+void Node::SetLayoutObject(LayoutObject* layout_object) {
+  NodeLayoutData* node_layout_data = HasRareData()
+                                         ? data_.rare_data_->GetNodeLayoutData()
+                                         : data_.node_layout_data_;
+
+  // Already pointing to a non empty NodeLayoutData so just set the pointer to
+  // // the new LayoutObject.

[esprehn, 2017/04/13 22:02:49]

extra //

[nainar, 2017/04/13 22:28:16]

I can't even. git cl format broke this I guess. Done. 

+  if (!node_layout_data->IsSharedEmptyData()) {
+    node_layout_data->SetLayoutObject(layout_object);
+    return;
+  }
+
+  if (!layout_object)
+    return;
+
+  // Swap the NodeLayoutData to point to a new NodeLayoutData instead of the //

[esprehn, 2017/04/13 22:02:49]

extra //

[nainar, 2017/04/13 22:28:16]

Done. 

+  // static SharedEmptyData instance.
+  node_layout_data = new NodeLayoutData(layout_object);
+  if (HasRareData())
+    data_.rare_data_->SetNodeLayoutData(node_layout_data);
+  else
+    data_.node_layout_data_ = node_layout_data;
+}
+
 LayoutBoxModelObject* Node::GetLayoutBoxModelObject() const {
   LayoutObject* layout_object = this->GetLayoutObject();
   return layout_object && layout_object->IsBoxModelObject()
              ? ToLayoutBoxModelObject(layout_object)
              : nullptr;
 }
 
 LayoutRect Node::BoundingBox() const {
   if (GetLayoutObject())
     return LayoutRect(GetLayoutObject()->AbsoluteBoundingBoxRect());
@@ skipping 1938 matching lines @@
   if (node) {
     std::stringstream stream;
     node->PrintNodePathTo(stream);
     LOG(INFO) << stream.str();
   } else {
     LOG(INFO) << "Cannot showNodePath for <null>";
   }
 }
 
 #endif