android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java - Issue 2814593002: WebView: add {set,get}SafeBrowsingEnabled per WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

Issue 2814593002: WebView: add {set,get}SafeBrowsingEnabled per WebView (Closed)

Patch Set: Add javatests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/apk/java/proguard.flags ('K') | « android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java ('k') | android_webview/java/src/org/chromium/android_webview/AwSettings.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java b/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

index a73f6cc361e27918c074411133df833a4212071e..26f7813a44019d825daaab9ce3bdea688a2ef106 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwServiceWorkerController.java

@@ -81,6 +81,12 @@ public class AwServiceWorkerController {

// see e.g. AwCookieAccessPolicy::GetShouldAcceptThirdPartyCookies.

return false;

}

+ @Override

+ public boolean getSafeBrowsingEnabled() {

+ // We don't allow safe browsing in service workers

+ return false;

sgurun-gerrit only 2017/04/11 00:38:52 return the value that is dictated by the manifest.

Nate Fischer 2017/04/11 00:58:02 done

+ }

}

private class ServiceWorkerBackgroundThreadClientImpl