chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java - Issue 2814533002: Adding a new annotation to set ChildProcessAllocator settings in tests.

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

Issue 2814533002: Adding a new annotation to set ChildProcessAllocator settings in tests. (Closed)

Patch Set: Introducing a new annotation to change child process allocator. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java » ('j') | content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettings.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

index 4874cd985abd5cd0dc589f291a5c24ee3a605ec5..efa5df228b06065f875032590699b7556ed73429 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java

@@ -11,7 +11,6 @@ import android.util.SparseArray;

import android.util.SparseBooleanArray;

import org.chromium.base.ThreadUtils;

-import org.chromium.base.test.util.CommandLineFlags;

import org.chromium.base.test.util.DisabledTest;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.Restriction;

@@ -29,6 +28,7 @@ import org.chromium.chrome.test.util.PrerenderTestHelper;

import org.chromium.content.browser.BindingManager;

import org.chromium.content.browser.ChildProcessConnection;

import org.chromium.content.browser.ChildProcessLauncher;

+import org.chromium.content.browser.test.ChildProcessAllocatorSettings;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

import org.chromium.content_public.browser.LoadUrlParams;

@@ -507,7 +507,7 @@ public class BindingManagerIntegrationTest extends ChromeActivityTestCaseBase<Ch

* Verifies that BindingManager.releaseAllModerateBindings() is called once all the sandboxed

* services are allocated.

- @CommandLineFlags.Add(ChildProcessLauncher.SWITCH_NUM_SANDBOXED_SERVICES_FOR_TESTING + "=4")

+ @ChildProcessAllocatorSettings(sandboxedServiceCount = 4)

boliu 2017/04/10 18:43:41 does this work yet for junit3 tests?

Jay Civelli 2017/04/10 19:43:15 I don't see why the version of junit should impact

@LargeTest

@Feature({"ProcessManagement"})

public void testReleaseAllModerateBindings() throws InterruptedException {