Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: media/cast/transport/rtp_sender/rtp_sender.cc

Issue 281453003: Cast: Simplify code path for RTCP sender report (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/transport/rtp_sender/rtp_sender.h ('k') | media/cast/transport/transport_audio_sender.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/transport/rtp_sender/rtp_sender.cc
diff --git a/media/cast/transport/rtp_sender/rtp_sender.cc b/media/cast/transport/rtp_sender/rtp_sender.cc
index 6c479bb46b77a1c14101d357473dc2c792a05890..0963bf719d214edeebb119a860ac7f9d8083bb65 100644
--- a/media/cast/transport/rtp_sender/rtp_sender.cc
+++ b/media/cast/transport/rtp_sender/rtp_sender.cc
@@ -13,18 +13,12 @@ namespace media {
namespace cast {
namespace transport {
-// Schedule the RTP statistics callback every 33mS. As this interval affects the
-// time offset of the render and playout times, we want it in the same ball park
-// as the frame rate.
-static const int kStatsCallbackIntervalMs = 33;
-
RtpSender::RtpSender(
base::TickClock* clock,
const scoped_refptr<base::SingleThreadTaskRunner>& transport_task_runner,
PacedSender* const transport)
: clock_(clock),
transport_(transport),
- stats_callback_(),
transport_task_runner_(transport_task_runner),
weak_factory_(this) {
// Randomly set sequence number start value.
@@ -142,30 +136,6 @@ void RtpSender::UpdateSequenceNumber(Packet* packet) {
(*packet)[index + 1] = (static_cast<uint8>(new_sequence_number >> 8));
}
-void RtpSender::SubscribeRtpStatsCallback(
- const CastTransportRtpStatistics& callback) {
- stats_callback_ = callback;
- ScheduleNextStatsReport();
-}
-
-void RtpSender::ScheduleNextStatsReport() {
- transport_task_runner_->PostDelayedTask(
- FROM_HERE,
- base::Bind(&RtpSender::RtpStatistics, weak_factory_.GetWeakPtr()),
- base::TimeDelta::FromMilliseconds(kStatsCallbackIntervalMs));
-}
-
-void RtpSender::RtpStatistics() {
- RtcpSenderInfo sender_info;
- base::TimeTicks time_sent;
- uint32 rtp_timestamp = 0;
- packetizer_->LastSentTimestamp(&time_sent, &rtp_timestamp);
- sender_info.send_packet_count = packetizer_->send_packets_count();
- sender_info.send_octet_count = packetizer_->send_octet_count();
- stats_callback_.Run(sender_info, time_sent, rtp_timestamp);
- ScheduleNextStatsReport();
-}
-
} // namespace transport
} // namespace cast
} // namespace media
« no previous file with comments | « media/cast/transport/rtp_sender/rtp_sender.h ('k') | media/cast/transport/transport_audio_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698