Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc

Issue 281453003: Cast: Simplify code path for RTCP sender report (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc
diff --git a/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc b/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc
index 5f0edc8c74cc4e9402288d52961511fff7829db6..0545461265bb25163be2c4aec89fbd3e45d001ae 100644
--- a/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc
+++ b/media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer_unittest.cc
@@ -73,9 +73,9 @@ class TestRtpPacketTransport : public PacketSender {
return true;
}
- int number_of_packets_received() const { return packets_sent_; }
+ size_t number_of_packets_received() const { return packets_sent_; }
- void set_expected_number_of_packets(int expected_number_of_packets) {
+ void set_expected_number_of_packets(size_t expected_number_of_packets) {
expected_number_of_packets_ = expected_number_of_packets;
}
@@ -85,9 +85,9 @@ class TestRtpPacketTransport : public PacketSender {
RtpPacketizerConfig config_;
uint32 sequence_number_;
- int packets_sent_;
- int number_of_packets_;
- int expected_number_of_packets_;
+ size_t packets_sent_;
+ size_t number_of_packets_;
+ size_t expected_number_of_packets_;
// Assuming packets arrive in sequence.
int expected_packet_id_;
uint32 expected_frame_id_;
@@ -142,7 +142,7 @@ class RtpPacketizerTest : public ::testing::Test {
};
TEST_F(RtpPacketizerTest, SendStandardPackets) {
- int expected_num_of_packets = kFrameSize / kMaxPacketLength + 1;
+ size_t expected_num_of_packets = kFrameSize / kMaxPacketLength + 1;
transport_->set_expected_number_of_packets(expected_num_of_packets);
transport_->set_rtp_timestamp(video_frame_.rtp_timestamp);
@@ -154,10 +154,10 @@ TEST_F(RtpPacketizerTest, SendStandardPackets) {
}
TEST_F(RtpPacketizerTest, Stats) {
- EXPECT_FALSE(rtp_packetizer_->send_packets_count());
+ EXPECT_FALSE(rtp_packetizer_->send_packet_count());
EXPECT_FALSE(rtp_packetizer_->send_octet_count());
// Insert packets at varying lengths.
- int expected_num_of_packets = kFrameSize / kMaxPacketLength + 1;
+ size_t expected_num_of_packets = kFrameSize / kMaxPacketLength + 1;
transport_->set_expected_number_of_packets(expected_num_of_packets);
transport_->set_rtp_timestamp(video_frame_.rtp_timestamp);
@@ -165,7 +165,7 @@ TEST_F(RtpPacketizerTest, Stats) {
rtp_packetizer_->IncomingEncodedVideoFrame(&video_frame_,
testing_clock_.NowTicks());
RunTasks(33 + 1);
- EXPECT_EQ(expected_num_of_packets, rtp_packetizer_->send_packets_count());
+ EXPECT_EQ(expected_num_of_packets, rtp_packetizer_->send_packet_count());
EXPECT_EQ(kFrameSize, rtp_packetizer_->send_octet_count());
EXPECT_EQ(expected_num_of_packets, transport_->number_of_packets_received());
}
« no previous file with comments | « media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.cc ('k') | media/cast/transport/rtp_sender/rtp_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698