Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: media/cast/transport/cast_transport_sender_impl.cc

Issue 281453003: Cast: Simplify code path for RTCP sender report (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/transport/cast_transport_sender_impl.cc
diff --git a/media/cast/transport/cast_transport_sender_impl.cc b/media/cast/transport/cast_transport_sender_impl.cc
index a3d7ca1f97b1bbc38daa7ef171aacf42d63399da..8d2a87130165c69e5b1702bfae2ce5bf40ceff5c 100644
--- a/media/cast/transport/cast_transport_sender_impl.cc
+++ b/media/cast/transport/cast_transport_sender_impl.cc
@@ -115,10 +115,26 @@ void CastTransportSenderImpl::InsertCodedVideoFrame(
void CastTransportSenderImpl::SendRtcpFromRtpSender(
uint32 packet_type_flags,
- const RtcpSenderInfo& sender_info,
+ uint32 ntp_seconds,
+ uint32 ntp_fraction,
+ uint32 rtp_timestamp,
const RtcpDlrrReportBlock& dlrr,
uint32 sending_ssrc,
const std::string& c_name) {
+ RtcpSenderInfo sender_info;
+ sender_info.ntp_seconds = ntp_seconds;
+ sender_info.ntp_fraction = ntp_fraction;
+ sender_info.rtp_timestamp = rtp_timestamp;
+ if (audio_sender_ && audio_sender_->ssrc() == sending_ssrc) {
+ sender_info.send_packet_count = audio_sender_->send_packet_count();
+ sender_info.send_octet_count = audio_sender_->send_octet_count();
+ } else if (video_sender_ && video_sender_->ssrc() == sending_ssrc) {
+ sender_info.send_packet_count = video_sender_->send_packet_count();
+ sender_info.send_octet_count = video_sender_->send_octet_count();
+ } else {
+ LOG(ERROR) << "Sending RTCP with an invalid SSRC.";
+ return;
+ }
rtcp_builder_.SendRtcpFromRtpSender(
packet_type_flags, sender_info, dlrr, sending_ssrc, c_name);
}
@@ -135,18 +151,6 @@ void CastTransportSenderImpl::ResendPackets(
}
}
-void CastTransportSenderImpl::SubscribeAudioRtpStatsCallback(
- const CastTransportRtpStatistics& callback) {
- DCHECK(audio_sender_) << "Audio sender uninitialized";
- audio_sender_->SubscribeAudioRtpStatsCallback(callback);
-}
-
-void CastTransportSenderImpl::SubscribeVideoRtpStatsCallback(
- const CastTransportRtpStatistics& callback) {
- DCHECK(video_sender_) << "Video sender uninitialized";
- video_sender_->SubscribeVideoRtpStatsCallback(callback);
-}
-
void CastTransportSenderImpl::SendRawEvents() {
DCHECK(event_subscriber_.get());
DCHECK(!raw_events_callback_.is_null());
« no previous file with comments | « media/cast/transport/cast_transport_sender_impl.h ('k') | media/cast/transport/rtp_sender/rtp_packetizer/rtp_packetizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698