Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: media/cast/transport/cast_transport_sender.h

Issue 281453003: Cast: Simplify code path for RTCP sender report (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/transport/cast_transport_sender.h
diff --git a/media/cast/transport/cast_transport_sender.h b/media/cast/transport/cast_transport_sender.h
index 1d3ac322c6b0de75c07ff3d43bb45397762bbd14..0714995f98c99ec0d65f0cd724e8edec5540b62a 100644
--- a/media/cast/transport/cast_transport_sender.h
+++ b/media/cast/transport/cast_transport_sender.h
@@ -45,10 +45,6 @@ namespace transport {
typedef base::Callback<void(CastTransportStatus status)>
CastTransportStatusCallback;
-typedef base::Callback<void(const RtcpSenderInfo& sender_info,
- base::TimeTicks time_sent,
- uint32 rtp_timestamp)> CastTransportRtpStatistics;
-
typedef base::Callback<void(const std::vector<PacketEvent>&)>
BulkRawEventsCallback;
@@ -88,8 +84,12 @@ class CastTransportSender : public base::NonThreadSafe {
const base::TimeTicks& capture_time) = 0;
// Builds an RTCP packet and sends it to the network.
+ // |ntp_seconds|, |ntp_fraction| and |rtp_timestamp| are used in the
+ // RTCP Sender Report.
virtual void SendRtcpFromRtpSender(uint32 packet_type_flags,
- const RtcpSenderInfo& sender_info,
+ uint32 ntp_seconds,
+ uint32 ntp_fraction,
+ uint32 rtp_timestamp,
const RtcpDlrrReportBlock& dlrr,
uint32 sending_ssrc,
const std::string& c_name) = 0;
@@ -98,15 +98,6 @@ class CastTransportSender : public base::NonThreadSafe {
virtual void ResendPackets(
bool is_audio,
const MissingFramesAndPacketsMap& missing_packets) = 0;
-
- // RTP statistics will be returned on a regular interval on the designated
- // callback.
- // Must be called after initialization of the corresponding A/V pipeline.
- virtual void SubscribeAudioRtpStatsCallback(
- const CastTransportRtpStatistics& callback) = 0;
-
- virtual void SubscribeVideoRtpStatsCallback(
- const CastTransportRtpStatistics& callback) = 0;
};
} // namespace transport

Powered by Google App Engine
This is Rietveld 408576698