GN: Add libdart_jit and dart_api.

GN: Add libdart_jit and dart_api.

libdart_jit is always the JIT, unlike libdart which is either the JIT or AOT runtime depending on dart_runtime_mode. Clients of libdart will be updated to explicitly choose libdart_jit or libdart_precompiled_runtime.

dart_api allows libraries such as tonic or intermediate components of the Flutter engine to be agnostic as to whether they're in a JIT or AOT runtime, allowing the final executable making the choice without having to deal with a conflicting dependency brought in by a library.

Remove dead libdart_embedder_noio.

Replace all used of dart_nosnapshot* with dart_nosnapshot_with_precompiler*. We don't care about binary size of their clients, so it's better to have fewer targets.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/42ec925a9e8be87e515f06440e01e11c832b8da7

[rmacnak, 2017-04-10 19:33:26]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2017-04-10 19:50:02]

https://codereview.chromium.org/2814513003/diff/1/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/2814513003/diff/1/runtime/BUILD.gn#newcode206
runtime/BUILD.gn:206: source_set("dart_api") {
So, to depend on a header file, you not only have to add the directory to
include_dirs, but also list the header file in sources?

https://codereview.chromium.org/2814513003/diff/1/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2814513003/diff/1/runtime/vm/BUILD.gn#newcode44
runtime/vm/BUILD.gn:44: static_library("libdart_vm") {
Is this still needed?

https://codereview.chromium.org/2814513003/diff/1/runtime/vm/BUILD.gn#newcode249
runtime/vm/BUILD.gn:249: static_library("libdart_lib") {
Is this still needed?

[rmacnak, 2017-04-10 20:30:11]

https://codereview.chromium.org/2814513003/diff/1/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/2814513003/diff/1/runtime/BUILD.gn#newcode206
runtime/BUILD.gn:206: source_set("dart_api") {
On 2017/04/10 19:50:02, zra wrote:
> So, to depend on a header file, you not only have to add the directory to
> include_dirs, but also list the header file in sources?

If the sources below are missing GN gives an error when parts of the engine with
a deps on //dart/runtime:dart_api but no variant of libdart say

#include "dart/runtime/include/dart_api.h"



If the include dir is missing, then when parts of the engine say

#include "dart/runtime/include/dart_tools_api.h"

then the internal include in dart_tools_api.h that says

#include "include/dart_tools_api.h"

fails.

https://codereview.chromium.org/2814513003/diff/1/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/2814513003/diff/1/runtime/vm/BUILD.gn#newcode44
runtime/vm/BUILD.gn:44: static_library("libdart_vm") {
On 2017/04/10 19:50:02, zra wrote:
> Is this still needed?

This can be removed after clients of libdart are updated. Added comment.

https://codereview.chromium.org/2814513003/diff/1/runtime/vm/BUILD.gn#newcode249
runtime/vm/BUILD.gn:249: static_library("libdart_lib") {
On 2017/04/10 19:50:02, zra wrote:
> Is this still needed?

This can be removed after clients of libdart are updated. Added comment.

[zra, 2017-04-10 20:36:04]

lgtm

[rmacnak, 2017-04-10 20:44:29]

Description was changed from

==========
GN: Add libdart_jit and dart_api.

libdart_jit is always the JIT, unlike libdart which is either the JIT or AOT
runtime depending on dart_runtime_mode. Clients of libdart will be updated to
explicitly choose libdart_jit or libdart_precompiled_runtime.

dart_api allows libraries such as tonic or intermediate components of the
Flutter engine to be agnostic as to whether they're in a JIT or AOT runtime,
allowing the final executable making the choice without having to deal with a
conflicting dependency brought in by a library.

Remove dead libdart_embedder_noio.

Replace all used of dart_nosnapshot* with dart_nosnapshot_with_precompiler*. We
don't care about binary size of their clients, so it's better to have fewer
targets.
==========

to

==========
GN: Add libdart_jit and dart_api.

libdart_jit is always the JIT, unlike libdart which is either the JIT or AOT
runtime depending on dart_runtime_mode. Clients of libdart will be updated to
explicitly choose libdart_jit or libdart_precompiled_runtime.

dart_api allows libraries such as tonic or intermediate components of the
Flutter engine to be agnostic as to whether they're in a JIT or AOT runtime,
allowing the final executable making the choice without having to deal with a
conflicting dependency brought in by a library.

Remove dead libdart_embedder_noio.

Replace all used of dart_nosnapshot* with dart_nosnapshot_with_precompiler*. We
don't care about binary size of their clients, so it's better to have fewer
targets.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/42ec925a9e8be87e515f06440e01e11c832b8da7
==========

[rmacnak, 2017-04-10 20:44:30]

Committed patchset #2 (id:20001) manually as
42ec925a9e8be87e515f06440e01e11c832b8da7 (presubmit successful).