Issue 2814473002: Move HttpStreamFactoryImpl::JobController UMA to a schedule upload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2814473002: Move HttpStreamFactoryImpl::JobController UMA to a schedule upload (Closed)

Created:
3 years, 8 months ago by xunjieli

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move HttpStreamFactoryImpl::JobController UMA to a schedule upload TEMP. need cleanup and test Need to move off main thread. BUG=

Patch Set 1 #

Patch Set 2 : need to move off main thread #

Patch Set 3 : check thread safety #

Patch Set 4 : self #

Patch Set 5 : add test #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -26 lines)			Patch
M	net/android/network_change_notifier_android.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/base/network_change_notifier.h	View	1 2	5 chunks	+21 lines, -1 line	0 comments	Download
M	net/base/network_change_notifier.cc	View	1 2 3	5 chunks	+21 lines, -1 line	0 comments	Download
M	net/http/http_stream_factory_impl.h	View	1 2	4 chunks	+9 lines, -1 line	0 comments	Download
M	net/http/http_stream_factory_impl.cc	View	1 2	3 chunks	+31 lines, -23 lines	0 comments	Download
M	net/http/http_stream_factory_impl_unittest.cc	View	1 2 3 4	1 chunk	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

xunjieli

Description was changed from ========== Move HttpStreamFactoryImpl::JobController UMA to a schedule upload BUG= ========== to ...

3 years, 8 months ago (2017-04-10 14:26:50 UTC) #1

xunjieli

3 years, 8 months ago (2017-04-10 14:35:40 UTC) #2

Description was changed from

==========
Move HttpStreamFactoryImpl::JobController UMA to a schedule upload


TEMP. need cleanup and test


BUG=
==========

to

==========
Move HttpStreamFactoryImpl::JobController UMA to a schedule upload


TEMP. need cleanup and test

Need to move off main thread.

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages