pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart - Issue 2814453005: Merge CommonElements and BackendHelpers!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)

Patch Set: merge with head Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/backend_usage.dart ('K') | « pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart

index 6351c7bbfb470b4cbe54d4174341e93996566cfc..07eb13c93f9afaa10cb3b5c8e24f7341f3fe2490 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart

@@ -49,7 +49,8 @@ class InterceptorEmitter extends CodeEmitterHelper {

Set<ClassEntity> classes =

backend.oneShotInterceptorData.getSpecializedGetInterceptorsFor(name);

parts.add(js.statement('#.# = #', [

- namer.globalObjectForLibrary(backend.helpers.interceptorsLibrary),

+ namer

+ .globalObjectForLibrary(backend.commonElements.interceptorsLibrary),

name,

buildGetInterceptorMethod(name, classes)

]));

@@ -65,8 +66,8 @@ class InterceptorEmitter extends CodeEmitterHelper {

InterceptorStubGenerator stubGenerator =

new InterceptorStubGenerator(compiler, namer, backend, closedWorld);

- String globalObject =

- namer.globalObjectForLibrary(backend.helpers.interceptorsLibrary);

+ String globalObject = namer

+ .globalObjectForLibrary(backend.commonElements.interceptorsLibrary);

for (jsAst.Name name in names) {

jsAst.Expression function =

stubGenerator.generateOneShotInterceptor(name);