Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/compiler/lib/src/js_backend/impact_transformer.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: merge with head Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/impact_transformer.dart
diff --git a/pkg/compiler/lib/src/js_backend/impact_transformer.dart b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
index 517fd908ebd22524ae5b05e1e90df8fa5cd02dc6..355c20c5e1021a6493b912831859d51deb4f6656 100644
--- a/pkg/compiler/lib/src/js_backend/impact_transformer.dart
+++ b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
@@ -24,7 +24,6 @@ import '../universe/use.dart'
import '../universe/world_impact.dart' show TransformedWorldImpact, WorldImpact;
import '../util/util.dart';
import 'backend.dart';
-import 'backend_helpers.dart';
import 'backend_impact.dart';
import 'backend_usage.dart';
import 'checked_mode_helpers.dart';
@@ -336,7 +335,7 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
class CodegenImpactTransformer {
final CompilerOptions _options;
final ElementEnvironment _elementEnvironment;
- final BackendHelpers _helpers;
+ final CommonElements _commonElements;
final BackendImpacts _impacts;
final CheckedModeHelpers _checkedModeHelpers;
final NativeData _nativeData;
@@ -351,7 +350,7 @@ class CodegenImpactTransformer {
CodegenImpactTransformer(
this._options,
this._elementEnvironment,
- this._helpers,
+ this._commonElements,
this._impacts,
this._checkedModeHelpers,
this._nativeData,
@@ -380,14 +379,14 @@ class CodegenImpactTransformer {
CheckedModeHelper helper =
_checkedModeHelpers.getCheckedModeHelper(type, typeCast: false);
if (helper != null) {
- StaticUse staticUse = helper.getStaticUse(_helpers);
+ StaticUse staticUse = helper.getStaticUse(_commonElements);
transformed.registerStaticUse(staticUse);
}
// We also need the native variant of the check (for DOM types).
helper =
_checkedModeHelpers.getNativeCheckedModeHelper(type, typeCast: false);
if (helper != null) {
- StaticUse staticUse = helper.getStaticUse(_helpers);
+ StaticUse staticUse = helper.getStaticUse(_commonElements);
transformed.registerStaticUse(staticUse);
}
}

Powered by Google App Engine
This is Rietveld 408576698